Skip to content

Commit

Permalink
test: Fix lint(ref. ethermint v0.22.0-sdk50-1)
Browse files Browse the repository at this point in the history
  • Loading branch information
dudong2 committed Aug 7, 2024
1 parent 2069216 commit 5ccd178
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 29 deletions.
37 changes: 14 additions & 23 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,46 +5,35 @@ run:

linters:
enable:
# - bodyclose
- deadcode
- depguard
- bodyclose
- dogsled
- dupl
- errcheck
- goconst
- gocritic
- gofmt
- goimports
- gofumpt
- revive
- gosec
- gosimple
- govet
- ineffassign
# - lll TODO: enable
- lll
- misspell
- nakedret
- prealloc
- exportloopref
- staticcheck
# - structcheck
- stylecheck
# - typecheck #TODO: enable
- typecheck
- unconvert
# - unparam
- unparam
- unused
- varcheck
- nolintlint
- asciicheck
# - exhaustive
- exportloopref
- gofumpt
- gomodguard
# - nestif
# - nlreturn
# - noctx
# - rowserrcheck
# - whitespace
# - wsl
- whitespace

issues:
exclude-rules:
Expand All @@ -57,6 +46,8 @@ issues:
max-same-issues: 50

linters-settings:
lll:
line-length: 150
dogsled:
max-blank-identifiers: 3
golint:
Expand All @@ -75,9 +66,9 @@ linters-settings:
gomodguard:
blocked:
versions: # List of blocked module version constraints
- https://github.com/etcd-io/etcd: # Blocked module with version constraint
version: ">= 3.4.10 || ~3.3.23" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
reason: "CVE-2020-15114; CVE-2020-15136; CVE-2020-15115" # Reason why the version constraint exists. (Optional)
- https://github.com/dgrijalva/jwt-go: # Blocked module with version constraint
version: ">= 4.0.0-preview1" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
reason: "CVE-2020-26160" # Reason why the version constraint exists. (Optional)
- https://github.com/etcd-io/etcd: # Blocked module with version constraint
version: ">= 3.4.10 || ~3.3.23" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
reason: "CVE-2020-15114; CVE-2020-15136; CVE-2020-15115" # Reason why the version constraint exists. (Optional)
- https://github.com/dgrijalva/jwt-go: # Blocked module with version constraint
version: ">= 4.0.0-preview1" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
reason: "CVE-2020-26160" # Reason why the version constraint exists. (Optional)
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
- [Pull Request Templates](#pull-request-templates)
- [Requesting Reviews](#requesting-reviews)
- [Reviewing Pull Requests](#reviewing-pull-requests)
- [Updating Documentation](#updating-documentation)
- [Forking](#forking)
- [Dependencies](#dependencies)
- [Protobuf](#protobuf)
Expand Down
7 changes: 3 additions & 4 deletions tests/integration_tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,11 @@ pytest -s -vv

If you're changing anything on the ethermint rpc, rerun the first command.


## Caching

You can enable Binary Cache to speed up the tests:

```
$ nix-env -iA cachix -f https://cachix.org/api/v1/install
$ cachix use ethermint
```
nix-env -iA cachix -f https://cachix.org/api/v1/install
cachix use ethermint
```
2 changes: 1 addition & 1 deletion x/feemarket/spec/01_concepts.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ The comparison of transaction gas price and the lower bound is implemented throu

::: tip
If the base fee decreases to a value below the global `MinGasPrice`, it is set to the `MinGasPrice`. This is implemented, so that the base fee can't drop to gas prices that wouldn't allow transactions to be accepted in the mempool, because of a higher `MinGasPrice`.
:::
:::

0 comments on commit 5ccd178

Please sign in to comment.