-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bkushigian/issue14 Serialize Tree/Card Configurations #50
Closed
bkushigian
wants to merge
73
commits into
b-inary:main
from
bkushigian:bkushigian/issue14-serde-tree-config
Closed
Bkushigian/issue14 Serialize Tree/Card Configurations #50
bkushigian
wants to merge
73
commits into
b-inary:main
from
bkushigian:bkushigian/issue14-serde-tree-config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating
Bkushigian/issue9 build errors
Documentation and Clarity Refactors
Refactor bet_size.rs for issue 16 Closes #16
jfc github will NOT stop sending PRs to this repo. This has been a bug in github for years. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving/loading tree/card configurations should be easy. The following data needs to be present when running a solve:
CardConfig
: containsTreeConfig
: used to build anActionTree
, this contains:BoardState
A couple things to think about:
card_config
's flop/turn/river determinetree_config
'sinitial_state
value, and this might be annoying for a user to fill out/can lead to buggy configurations.For now, having an easy way to load/save configs and use to solve sets of flops will be very useful