refactor try catch

b310-digital · Nov 19, 2024 · f9ab64e · f9ab64e
1 parent 066a9a6
commit f9ab64e
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/teammapper-backend/src/map/controllers/maps.controller.ts b/teammapper-backend/src/map/controllers/maps.controller.ts
@@ -23,15 +23,18 @@ export default class MapsController {
 
   @Get(':id')
   async findOne(@Param('id') mapId: string): Promise<IMmpClientMap | void> {
-    // If we update lastAccessed first, we guarantee that the exportMapToClient returns a fresh map that includes an up-to-date lastAccessed field
-    await this.mapsService.updateLastAccessed(mapId).catch((e: Error) => {
-      if (e instanceof MalformedUUIDError || e instanceof EntityNotFoundError) throw new NotFoundException()
-    })
+    try {
+      // If we update lastAccessed first, we guarantee that the exportMapToClient returns a fresh map that includes an up-to-date lastAccessed field
+      await this.mapsService.updateLastAccessed(mapId)
+      const map = await this.mapsService.exportMapToClient(mapId)
+      if (!map) throw new NotFoundException()
 
-    const map = await this.mapsService.exportMapToClient(mapId)
-    if (!map) throw new NotFoundException()
+      return map
+    } catch(e) {
+      if (e instanceof MalformedUUIDError || e instanceof EntityNotFoundError) throw new NotFoundException()
+    }
 
-    return map
+
   }
 
   @Delete(':id')