Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This has a lot of changes on CI and stage #394

Closed
wants to merge 49 commits into from

Conversation

goern
Copy link
Member

@goern goern commented Aug 21, 2023

  • ✨ update mosquitto version to 2.0.16
  • a little more cleanup of manifests
  • convert paddock's deploymentConfig to deployment, remove paddock imageStream
  • add pipelineascode config for nostromo-stage environment
  • fix the service port name of paddock
  • add grafana to nostromo stage environment
  • fix secret name of pitwall ingress in nostromo-stage
  • add common component label to grafana manifests
  • add influx-grafana auth secret to nostromo-stage
  • some grafana cleanup

@op1st-prow op1st-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
@op1st-prow
Copy link

op1st-prow bot commented Aug 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@op1st-prow
Copy link

op1st-prow bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from goern. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@op1st-prow op1st-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 21, 2023
@op1st-prow op1st-prow bot requested a review from durandom August 21, 2023 06:49
@goern
Copy link
Member Author

goern commented Aug 21, 2023

/test all

@goern goern changed the title nostromo stage This as a lot of changes on CI and stage Aug 21, 2023
@op1st-prow op1st-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 21, 2023
@goern goern changed the title This as a lot of changes on CI and stage This has a lot of changes on CI and stage Aug 21, 2023
@goern
Copy link
Member Author

goern commented Aug 21, 2023

/test all

@goern goern force-pushed the nostromo-stage branch 3 times, most recently from 5802995 to b7a1cc0 Compare August 21, 2023 12:38
@op1st-prow op1st-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 21, 2023
@goern goern marked this pull request as ready for review August 22, 2023 07:06
@op1st-prow op1st-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2023
@op1st-prow op1st-prow bot requested a review from durandom August 22, 2023 07:07
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is only touching nostromo env, so LGTM

the grafana secrets issue is ok with me, to be solved later, once we actually have dev environments or kind clusters

@@ -1,8 +0,0 @@
kind: Secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant we keep those and the influx-grafana-auth as a default?
For a development environment where we don't want sealed secrets, or a kind cluster.

IIRC I kept those, because I cant remove resources in overlays.
But it might be possible according to
kubernetes-sigs/kustomize#1593 (comment)

@goern goern force-pushed the nostromo-stage branch 2 times, most recently from 2d4e413 to 35a2da4 Compare August 24, 2023 14:21
@op1st-prow op1st-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 4, 2023
@goern goern force-pushed the nostromo-stage branch 3 times, most recently from 9f89460 to d97a598 Compare September 7, 2023 06:11
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
* 🧼 correction(commitizen): remove commitizen from the dev environment

Signed-off-by: Christoph Görn <[email protected]>

* fix: add ingressClassName where it was missing before

Signed-off-by: Christoph Görn <[email protected]>

---------

Signed-off-by: Christoph Görn <[email protected]>
@goern
Copy link
Member Author

goern commented Dec 17, 2023

/close

@op1st-prow op1st-prow bot closed this Dec 17, 2023
Copy link

op1st-prow bot commented Dec 17, 2023

@goern: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants