-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This has a lot of changes on CI and stage #394
Conversation
goern
commented
Aug 21, 2023
•
edited
Loading
edited
- ✨ update mosquitto version to 2.0.16
- a little more cleanup of manifests
- convert paddock's deploymentConfig to deployment, remove paddock imageStream
- add pipelineascode config for nostromo-stage environment
- fix the service port name of paddock
- add grafana to nostromo stage environment
- fix secret name of pitwall ingress in nostromo-stage
- add common component label to grafana manifests
- add influx-grafana auth secret to nostromo-stage
- some grafana cleanup
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/test all |
5802995
to
b7a1cc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this is only touching nostromo env, so LGTM
the grafana secrets issue is ok with me, to be solved later, once we actually have dev environments or kind clusters
@@ -1,8 +0,0 @@ | |||
kind: Secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cant we keep those and the influx-grafana-auth as a default?
For a development environment where we don't want sealed secrets, or a kind cluster.
IIRC I kept those, because I cant remove resources in overlays.
But it might be possible according to
kubernetes-sigs/kustomize#1593 (comment)
2d4e413
to
35a2da4
Compare
b536f5a
to
cc67d84
Compare
9f89460
to
d97a598
Compare
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
Signed-off-by: Christoph Görn <[email protected]>
* 🧼 correction(commitizen): remove commitizen from the dev environment Signed-off-by: Christoph Görn <[email protected]> * fix: add ingressClassName where it was missing before Signed-off-by: Christoph Görn <[email protected]> --------- Signed-off-by: Christoph Görn <[email protected]>
/close |
@goern: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |