Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IFCTunnelDep3_Geo.ifc #154

Merged

Conversation

larswik
Copy link
Collaborator

@larswik larswik commented Jun 13, 2023

First attempt for sprint 3_geo.

File

Example file for sprint 3_geo. Contains all concepts from sprints 1 and 2 plus:

  1. IfcBorehole

  2. IfcGeoScienceObservation/BOREHOLELOG

  3. IfcDatasetInformation

  4. IfcGeoScienceModel/PHYSICALPROPERTYDISTRIBUTIONMODEL

  5. IfcGeoScienceFeature/PHYSICALPROPERTYDISTRIBUTION.

I might add IfcTunnelTypicalSection for Book C later. Right now the library I use (GeometryGym), for natural reasons does not contain IfcTunnelTypicalSection yet (added recently to the specification).

Covered Concept Templates - Usages Included

All concept templates from sprints 1 and 2. All required concept templates for the entities listed above.

Miscellaneous

Added IfcRealVoxelData (with dummy data).
Proposed a structure where IfcRealVoxelData and IfcGeoScienceFeature share IfcShapeRepresentation=>IfcVoxelGrid and IfcRealVoxelData=>IfcRelAssignsToProduct=>IfcGeoScienceFeature.
@pjanck
Copy link
Member

pjanck commented Sep 16, 2023

@larswik Please merge from main, there is a change necessary to activate the checker.

Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at bookA example, and also not everything.

files/project_team/IFCTunnelDep3_Geo_BookA.ifc Outdated Show resolved Hide resolved
@pjanck
Copy link
Member

pjanck commented Dec 5, 2023

The checker complains about IfcLengthMeasure in IfcCurveMeasureSelect, as noted above, otherwise both files seem OK.

@larswik
Copy link
Collaborator Author

larswik commented Dec 5, 2023

The checker complains about IfcLengthMeasure in IfcCurveMeasureSelect, as noted above, otherwise both files seem OK.

Aha, thanks! This comes from the old LandXML=>IFC converter which obviously uses IfcLengthMeasure instead of IfcNonNegativeLengthMeasure as it should be. I will fix this.

@pjanck
Copy link
Member

pjanck commented Dec 5, 2023

uses IfcLengthMeasure instead of IfcNonNegativeLengthMeasure as it should be

The other way around, I believe.

@larswik
Copy link
Collaborator Author

larswik commented Dec 5, 2023

uses IfcLengthMeasure instead of IfcNonNegativeLengthMeasure as it should be

The other way around, I believe.

image
I think that you want IfcNonNegativeLengthMeasure, or?

@pjanck
Copy link
Member

pjanck commented Dec 5, 2023

I think that you want IfcNonNegativeLengthMeasure, or?

You're right, my bad!

@pjanck pjanck merged commit c862ec1 into bSI-InfraRoom:main Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants