Create sprint-1-2_18inchPipePile_bridgeSI_Georef_A #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This IFC file satisfies the requirements set forth by sprint 1.1, and it has been generated wholly by the Bridge Software Institute (University of Florida).
ashishlov-uf
requested review from
SergejMuhic,
larswik and
pjanck
as code owners
|
Please rename the file to have a file ending |
…e_bridgeSI.ifc Renamed file to include ".ifc" extension.
File has been renamed, thanks for catching that. |
|
One question, how did you get IfcSolidStratum into an IFC4 file? This is quite disconcerting. Not checked in this sprint but that would be quite a hard violation i.e. foundation for "IFC not working" statements. |
larswik
requested changes
Feb 14, 2023
ashishlov-uf
changed the title
…2_18inchPipePile_bridgeSI_Georef_A.ifc -Revised file based on comments related to sprint 1-1. -Added content based on requirements of sprint 1-2 Georef_A.
pjanck
approved these changes
Feb 24, 2023
| #91 = IFCSITE('2q0A6$eDbEJx$bZGM8f7tv', $, 'Default Bridge', $, $, #24, $, $, .ELEMENT., (0, 0, 0), (0, 0, 0), 0., $, $); | ||
| #92 = IFCRELAGGREGATES('2w4vtdhVoEH810nVKpCtY1', $, 'Project Bin', 'Project to Spatial Element', #1, (#91)); | ||
|
|
||
| #93= IFCPROJECTEDCRS('EPSG:12364',$,$,$,$,$,$); |
There was a problem hiding this comment.
Out of curiosity: I can't find any reference to this EPSG code - can you provide a link to a source? (If you have simply made up the number, we encourage you to use a valid EPSG number, e.g. from https://epsg.io/ - the files are observed by domain experts as well 🚀)
larswik
approved these changes
Apr 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File
Provide a short summary (3-5 lines):
For example, is it a new file, an update to an existing one?
Provide some bullet points about the content of the file, e.g. terrain model, tunnel structure, etc.
This is a new IFC file that satisfies the requirements set forth by sprint 1.1, and it has been generated wholly by the Bridge Software Institute (University of Florida).
The file describes a steel pipe pile that has been driven into a layer of sand.
Covered Concept Templates - Usages Included
Please list all Usages you have implemented.
Project Unit Assignment
-Plane Angle Unit is satisfied
Project Representation Context
-3D is satisfied
Project Declaration
-IfcActor is satisfied
Miscellaneous
Please use this area to convey anything else.