Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Case]: Alignment Curves #1

Closed
wants to merge 14 commits into from

Conversation

SergejMuhic
Copy link
Collaborator

@SergejMuhic SergejMuhic commented Dec 19, 2021

Summary

Outline of the content and tasks addressed by this pull request, dont forget to link the relevent issue(s)

Resolves #4

Adding test instruction first stage documentation for [Test Case]: Alignment Curves

Tagging @JuhaHy

Purpose

Please mark the relevent tasks that this pull request creates or updates:

Test Cases

  • Creation of new test case
  • Test case summary
  • Itemised roots & test case imports
  • Usages, constraints & logic
  • Validation criteria & Results
  • Dataset Content & Documentation

@SergejMuhic SergejMuhic self-assigned this Dec 19, 2021
@SergejMuhic SergejMuhic marked this pull request as draft December 19, 2021 17:15
@AlexBrad1eyCT AlexBrad1eyCT changed the title TC 1.1 Alignment Curve linear reference geospatial [Test Case]: Alignment Curves Jan 2, 2022
@AlexBrad1eyCT AlexBrad1eyCT added test case issues & pull requests relating to test cases documentation Improvements or additions to documentation labels Jan 2, 2022
@AlexBrad1eyCT
Copy link
Collaborator

AlexBrad1eyCT commented Jan 3, 2022

@SergejMuhic, few things initially:

  1. You missed the test case folder, path to the md file should be /E1-ALRF/ALIGN/Readme.md, see the folder template XXXX in docs, the readme links should work if you use the suggested coding.
  2. Can you update to the new template also it has a few extra bits for identification and doc control
  3. It should be a test case per pull request, not exchange per PR can you split linear placement in to a separate one as I feel when we get to the files there is going to be quite alot of discusssion

PS well done on being first! 😄

@SergejMuhic
Copy link
Collaborator Author

SergejMuhic commented Jan 3, 2022

@SergejMuhic, few things initially:

1. You missed the test case folder, path to the md file should be /E1-ALRF/ALIGN/Readme.md, see the folder template XXXX in docs, the readme links should work if you use the suggested coding.

2. Can you update to the new template also it has a few extra bits for identification and doc control

3. It should be a test case per pull request, not exchange per PR can you split linear placement in to a separate one as I feel when we get to the files there is going to be quite alot of discusssion

PS well done on being first! 😄

Addressed the points. Think I got it now. One question though on the every test instruction having its own PR. Branching of that should then be done on my fork, are we sure that everyone understands that?

@AlexBrad1eyCT
Copy link
Collaborator

AlexBrad1eyCT commented Jan 3, 2022

i does say that in the Contributing guidelines, i will mention it tomorrow, I always use branches on my fork because i am usually addressing more than one item at a time and try to seperate my changes.

@SergejMuhic
Copy link
Collaborator Author

Closing this PR to account for branching.

@SergejMuhic SergejMuhic closed this Jan 5, 2022
SergejMuhic pushed a commit that referenced this pull request Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test case issues & pull requests relating to test cases
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Test Case]: Alignment Curves
2 participants