Use $GITLIB env-var when set #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkdude
reviewed
Oct 10, 2023
bbin
Outdated
| coords (val (first script-deps)) | ||
| gitlibs-root (if-let [override (not-empty (System/getenv "GITLIBS"))] | ||
| override | ||
| "~/.gitlibs")] |
There was a problem hiding this comment.
Hardcoding the "/" will maybe not works on Windows, which is probably why @rads had the other logic before. Can you revert that change?
There was a problem hiding this comment.
Sure. Does the tilde work on Windows?
There was a problem hiding this comment.
This works because of the expand-home call later on
There was a problem hiding this comment.
Just writing (str (fs/path (fs/home) ".gitlibs")) would probably the least magic.
Use Windows friendly path when GITLIBS is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer the following questions and leave the below in as part of your PR.