adds maven for dep search

[agzam]

Please answer the following questions and leave the below in as part of your PR.

• This PR corresponds to an add maven search #41

• I have updated the CHANGELOG.md file with a description of the addressed issue.

Aww. Only after figuring this out I just realized there's #162 with a comment. Just following and grabbing that code would've been maybe simpler 🤦

Tested with the following:

$> ./neil dep search clojure
./neil dep search clojure
;; Tons of results from both Maven and Clojars

$> ./neil dep search "org.clojure/clojurescript"

./neil dep search "org.clojure/clojurescript"
Unable to find org.clojure/clojurescript on Clojars.
:lib org.clojure/clojurescript :version "1.11.121" :description "org.clojure/clojurescript on Maven"


$> ./neil dep search "org.clojure/clojure"

./neil dep search "org.clojure/clojure"
Unable to find org.clojure/clojure on Clojars.
:lib org.clojure/clojure-install :version "0.1.21" :description "org.clojure/clojure-install on Maven"
:lib org.clojure/clojure-contrib :version "1.2.0" :description "org.clojure/clojure-contrib on Maven"
:lib org.clojure/clojure :version "1.12.0-alpha5" :description "org.clojure/clojure on Maven"


$> ./neil dep search "clojurefoo"
./neil dep search "clojurefoo"
Unable to find clojurefoo on Maven.
Unable to find clojurefoo on Clojars.


$> ./neil dep search ""
;; produces help info

$> ./neil dep search 123
;; produces help info

$> ./neil dep search '123'
;; produces help info

Also neil.el was adjusted for the changes

[borkdude]

If this is still a work in progress, can you mark the PR as draft? And then ping me for a review when done?

[agzam]

If this is still a work in progress, can you mark the PR as draft? And then ping me for a review when done?

Apologies for constantly buzzing you with change notifications. I thought I was done, but then I realized that Emacs counterpart needs updating too.
Seemingly small change turned out to be a bit tricky. It's all good now - I checked it with different inputs. Thank you for your patience.

[borkdude]

Great, I'll have a look tomorrow!

[borkdude]

Aww. Only after figuring this out I just realized there's #162 with a comment. Just following and grabbing that code would've been maybe simpler 🤦

Do you still want give action to this or keep your current code?

[agzam]

Do you still want give action to this or keep your current code?

I glanced over it, looks like it does pretty much almost the same thing. Either way, the bottom line - it works. If you have no objections, perhaps let's merge it and close both tickets. wdyt?

Oh wait. I stand corrected. It also adds GitHub too. We can leave "improve search" ticket open. I may take a look and try adding GH at some point.

[agzam]

This number may seem speculative, no? I copypasted it as is from the documentation. Should we leave it at that or maybe increase it, I don't know to 50 or even more? But is it even sensible to try to get more results than this?

[borkdude]

Don't know to be honest

[borkdude]

I think adding a test here would be in order:

neil/tests.clj

Lines 78 to 91 in ff7aca4

	(deftest dep-search-test
	(is (thrown? java.lang.Exception (run-dep-subcommand "search" "someBougusLibThatDoesntExist")))
	(is (not-empty (run-dep-subcommand "search" "hiccups")))
	(is (some #(str/starts-with? % ":lib hiccups/hiccups")
	(run-dep-subcommand "search" "hiccups")))
	(is (some #(re-matches #":lib hiccups/hiccups :version \"\d+(\.\d+)+\" :description .*" %)
	(run-dep-subcommand "search" "hiccups")))
	(is (some #(re-matches #":lib macchiato/hiccups :version \"\d+(\.\d+)+\" :description .*" %)
	(run-dep-subcommand "search" "hiccups")))
	; tests for no NPEs/json parsing exceptions
	#_(is (any? (run-dep-subcommand "search" "org.clojure/tools.cli")))
	(is (any? (run-dep-subcommand "search" "babashka nrepl")))
	(is (thrown-with-msg? Exception #"Unable to find"
	(run-dep-subcommand "search" "%22searchTermThatIsn'tFound"))))

E.g. a test which searches for clojure on maven. After that, I think it'd be good to merge.