Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping of the JSON parsing #2

Closed
wants to merge 4 commits into from
Closed

Allow skipping of the JSON parsing #2

wants to merge 4 commits into from

Conversation

jansiwy
Copy link
Member

@jansiwy jansiwy commented Jan 25, 2024 •
edited
Loading

... even if the payload is JSON. That's useful for events sent by ElastiCache to SNS, as the JSON payload does not have well-defined JSON keys, but the JSON keys are actually part of the payload.

Please review by ignoring whitespaces.

@jansiwy
Allow to skip the JSON parsing
c567f9a 
... even if the payload is JSON.
@jansiwy jansiwy self-assigned this Jan 25, 2024
@jansiwy jansiwy changed the title Allow to skip the JSON parsing Allow skipping the JSON parsing Jan 25, 2024
@jansiwy jansiwy changed the title Allow skipping the JSON parsing Allow skipping of the JSON parsing Jan 25, 2024
@jansiwy jansiwy marked this pull request as ready for review January 25, 2024 13:35
@jansiwy jansiwy requested a review from a team January 25, 2024 13:35
@jansiwy
Copy link
Member Author

jansiwy commented Jan 25, 2024

This crashes with Invalid value for "v" parameter: cannot convert object to map of any single type, as the different states can't be maps (different subtypes) and they can't be objects (as objects with different keys can't be merged).

@jansiwy jansiwy added the invalid This doesn't seem right label Jan 25, 2024
@jansiwy jansiwy closed this Jan 25, 2024
@jansiwy jansiwy deleted the allow-skipping-json-parsing branch January 25, 2024 18:07
@jansiwy jansiwy mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtsaito jtsaito jtsaito approved these changes

Assignees

@jansiwy jansiwy

Labels
invalid This doesn't seem right
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jansiwy @jtsaito