Skip to content

Commit

Permalink
Added test to all upgrade schedule files
Browse files Browse the repository at this point in the history
Task: BABEL-2170

Signed-off-by: Deepakshi Mittal <[email protected]>
  • Loading branch information
deepakshi-mittal committed Dec 28, 2023
1 parent eedbca5 commit f016738
Show file tree
Hide file tree
Showing 20 changed files with 23 additions and 3 deletions.
7 changes: 4 additions & 3 deletions contrib/babelfishpg_tsql/src/hooks.c
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,8 @@ plsql_TriggerRecursiveCheck(ResultRelInfo *resultRelInfo)
/**
* Hook function to skip rewriting VIEW with base table if the VIEW has an instead of trigger
* Checks if view have an INSTEAD OF trigger at statement level
* If it does, we don't want to treat it as auto-updatable.
* If it does, we don't want to treat it as auto-updatable.
* This function also does error checking for recursive triggers
* Reference - src/backend/rewrite/rewriteHandler.c view_has_instead_trigger
*/
static bool
Expand All @@ -746,11 +747,11 @@ pltsql_bbfViewHasInsteadofTrigger(Relation view, CmdType event)
prev_tgoid = lfirst_oid(list_tail(triggerInvocationSequence));
if (prev_tgoid == current_tgoid)
{
return false; /** Direct recursive trigger case*/
return false; /** A trigger called recursively by itself*/
}
else if (list_member_oid(triggerInvocationSequence, current_tgoid))
{
/** Indirect recursive trigger case*/
/** A trigger called recursively by another trigger */
ereport(ERROR,
(errcode(ERRCODE_SYNTAX_ERROR),
errmsg("Maximum stored procedure, function, trigger, or view nesting level exceeded (limit 32)")));
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/13_4/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/13_5/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/13_6/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/13_7/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/13_8/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/13_9/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_10/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ BABEL-1062
BABEL-1243
BABEL-1493
BABEL-1963
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_11/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ BABEL-1062
BABEL-1243
BABEL-1493
BABEL-1963
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_3/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_5/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_6/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_7/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_8/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/14_9/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ BABEL-1062
BABEL-1243
BABEL-1493
BABEL-1963
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/15_1/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/15_2/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/15_3/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/15_4/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down
1 change: 1 addition & 0 deletions test/JDBC/upgrade/15_5/schedule
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ BABEL-1963
BABEL-1994-CHAR
BABEL-1994-VARCHAR
BABEL-2086
BABEL-2170
BABEL-2203
BABEL-2208
BABEL-2257
Expand Down

0 comments on commit f016738

Please sign in to comment.