Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting a DATE literal without time part to TIME datatype fails #1657

Open
wants to merge 43 commits into
base: BABEL_3_X_DEV
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
3113bd6
Casting a DATE literal without time part to TIME datatype fails
Suthapalli-Ramya-satya-vasavi-srija Jul 19, 2023
94c338e
Added hook and modified the tests
Suthapalli-Ramya-satya-vasavi-srija Aug 7, 2023
15364ef
Merge branch 'BABEL_3_X_DEV' into jira-babel-1528-vasavi
Suthapalli-Ramya-satya-vasavi-srija Aug 7, 2023
63994c6
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Aug 14, 2023
5970208
Add support for 'dd mon yyyy' syntax and add tests
Suthapalli-Ramya-satya-vasavi-srija Aug 14, 2023
5abb533
Fix build failure
Suthapalli-Ramya-satya-vasavi-srija Aug 14, 2023
ef3b0a5
Empty commit
Suthapalli-Ramya-satya-vasavi-srija Aug 14, 2023
aeaaf58
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Aug 16, 2023
425667a
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Aug 22, 2023
45d14ee
Rename hooks, add hook for handling month case and add tests
Suthapalli-Ramya-satya-vasavi-srija Aug 22, 2023
8d0cead
Merge branch 'BABEL_3_X_DEV' into jira-babel-1528-vasavi
Suthapalli-Ramya-satya-vasavi-srija Sep 7, 2023
5256372
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Sep 14, 2023
2b52253
Removed all the logic and called a separate function to handle time d…
Suthapalli-Ramya-satya-vasavi-srija Sep 19, 2023
165e5bf
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Sep 19, 2023
8438f2a
Implemented to-do parts and formatting
Suthapalli-Ramya-satya-vasavi-srija Sep 28, 2023
d129287
Merge branch 'BABEL_3_X_DEV' into jira-babel-1528-vasavi
Suthapalli-Ramya-satya-vasavi-srija Sep 28, 2023
95f935e
Empty commit
Suthapalli-Ramya-satya-vasavi-srija Sep 28, 2023
83c5c9b
Remove additional changes came when merging
Suthapalli-Ramya-satya-vasavi-srija Sep 28, 2023
9d9e3bc
Modified the formatting and comments
Suthapalli-Ramya-satya-vasavi-srija Oct 4, 2023
a545dee
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Oct 4, 2023
1be81a1
Removed unused variables
Suthapalli-Ramya-satya-vasavi-srija Oct 4, 2023
4e77880
Added comments for code
Suthapalli-Ramya-satya-vasavi-srija Oct 5, 2023
897c4fa
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Oct 11, 2023
a317305
Formatting fixes and new fixes implementation for offset
Suthapalli-Ramya-satya-vasavi-srija Oct 11, 2023
f7c6a26
Include correct header files
Suthapalli-Ramya-satya-vasavi-srija Oct 11, 2023
aa54d49
Remove unnecessary changes from tsqlIface.cpp file
Suthapalli-Ramya-satya-vasavi-srija Oct 11, 2023
ae5430d
Implemented validation of dates like 02000-2-2 and added tests for it
Suthapalli-Ramya-satya-vasavi-srija Oct 12, 2023
e9457a6
Resolve failures
Suthapalli-Ramya-satya-vasavi-srija Oct 12, 2023
b5f22b9
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Oct 12, 2023
a59fa96
Accept 0's infront of year and date only if text month is present
Suthapalli-Ramya-satya-vasavi-srija Oct 12, 2023
3ce386a
Merge branch 'BABEL_3_X_DEV' into jira-babel-1528-vasavi
Suthapalli-Ramya-satya-vasavi-srija Oct 18, 2023
edf89fb
Moved the logic to babelfish_common and fixed indentation and added m…
Suthapalli-Ramya-satya-vasavi-srija Oct 18, 2023
c143d3f
Removed unwanted changes and added the test to all schedule files
Suthapalli-Ramya-satya-vasavi-srija Oct 19, 2023
58061ea
Fix upgrade test failures and also covered positive case for hh:mm:ss…
Suthapalli-Ramya-satya-vasavi-srija Oct 20, 2023
a222981
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Oct 20, 2023
71aa6b5
Empty commit to check if the tests are failing againa
Suthapalli-Ramya-satya-vasavi-srija Oct 20, 2023
9201ca5
Support '' for casting to time and addressed comments in the pr
Suthapalli-Ramya-satya-vasavi-srija Oct 23, 2023
4e9b59b
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Oct 24, 2023
4c1c577
Empty commit
Suthapalli-Ramya-satya-vasavi-srija Oct 24, 2023
1f342f3
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Jan 3, 2024
47150ec
Merge branch 'babelfish-for-postgresql:BABEL_3_X_DEV' into jira-babel…
Suthapalli-Ramya-satya-vasavi-srija Jan 23, 2024
35617aa
Added more cases related to tim(HH:MM:SS:nnn) and restricted the date…
Suthapalli-Ramya-satya-vasavi-srija Jan 23, 2024
eae2cc4
Increased sla for parallel-query-mode, and added a case where code co…
Suthapalli-Ramya-satya-vasavi-srija Jan 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions contrib/babelfishpg_common/src/babelfishpg_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "parser/parse_collate.h"
#include "parser/parse_target.h"
#include "parser/scansup.h" /* downcase_identifier */
#include "utils/date.h"
#include "utils/guc.h"

#include "babelfishpg_common.h"
Expand Down Expand Up @@ -44,6 +45,7 @@ PreCreateCollation_hook_type prev_PreCreateCollation_hook = NULL;
set_like_collation_hook_type prev_set_like_collation_hook = NULL;
get_like_collation_hook_type prev_get_like_collation_hook = NULL;

tsql_time_in_hook_type prev_tsql_time_in_hook = NULL;

/* Module callbacks */
void _PG_init(void);
Expand Down Expand Up @@ -148,6 +150,9 @@ _PG_init(void)
prev_get_like_collation_hook = get_like_collation_hook;
get_like_collation_hook = bbf_get_like_collation;

prev_tsql_time_in_hook = tsql_time_in_hook;
tsql_time_in_hook = pltsql_time_in;

}
void
_PG_fini(void)
Expand All @@ -160,6 +165,7 @@ _PG_fini(void)
PreCreateCollation_hook = prev_PreCreateCollation_hook;
set_like_collation_hook = prev_set_like_collation_hook;
get_like_collation_hook = prev_get_like_collation_hook;
tsql_time_in_hook = prev_tsql_time_in_hook;
}

common_utility_plugin *
Expand Down
Loading
Loading