Support repeatable read and serializable isolation level #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanscorpio7
changed the title
tanscorpio7
changed the title
tanscorpio7
force-pushed
the
BABEL_4146
branch
from
0c2c257 to
0d9107c
Compare
surendravishnoi
previously approved these changes
Aug 24, 2023
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
tanscorpio7
changed the title
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
tanscorpio7
changed the title
Signed-off-by: Tanzeel Khan <[email protected]>
| @@ -1207,6 +1212,8 @@ int escape_hatch_rowversion = EH_STRICT; | |||
| int escape_hatch_showplan_all = EH_STRICT; | |||
| int escape_hatch_checkpoint = EH_IGNORE; | |||
| int escape_hatch_set_transaction_isolation_level = EH_STRICT; | |||
| int pltsql_isolation_level_repeatable_read = ISOLATION_OFF; | |||
| int pltsql_isolation_level_serializable = ISOLATION_OFF; | |||
There was a problem hiding this comment.
Not sure why this it is off, both are 2 tabs & 1 space
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
surendravishnoi
previously approved these changes
Oct 25, 2023
surendravishnoi
approved these changes
Oct 26, 2023
shardgupta
merged commit 9fab304
into
babelfish-for-postgresql:BABEL_3_X_DEV
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we do not support repeatable read and serializable isolation levels.
With this PR
BABEL repeatable read → PG repeatable read (if repeatable read escape hatch is set to pg_isolation)
BABEL serializable → PG serializable (if serializable escape hatch is set to pg_isolation)
REPEATABLE READ GUC:- 'repeatable_read_isolation'
SERIALIZABLE GUC:- 'serializable_isolation'
Issues Resolved
BABEL-4146 & BABEL-4145
Test Scenarios Covered
JDBC : Setting the GUC/ setting all different isolation level.
Python : Concurrent transaction run with one of them being repeatable read while other is read committed. Steps like select, update, delete, insert are used. Different permutations are run to force read/write, write/write concurrency.
Signed-off-by: Tanzeel Khan [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.