Fix the issue of preserving case of column names in SELECT corrname.colname. #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepesh125
requested changes
Sep 27, 2023
riyajain39
force-pushed
the
Jira-Babel-4279
branch
2 times, most recently
from
870ac7b to
1fade89
Compare
Deepesh125
reviewed
Oct 4, 2023
riyajain39
force-pushed
the
Jira-Babel-4279
branch
from
a62ab18 to
87c82dc
Compare
added 9 commits
October 10, 2023 05:20
…olname. Signed-off-by: Riya Jain <[email protected]>
Signed-off-by: Riya Jain <[email protected]>
…cluding multibyte characters. Signed-off-by: Riya Jain <[email protected]>
Signed-off-by: Riya Jain <[email protected]>
Signed-off-by: Riya Jain <[email protected]>
Signed-off-by: Riya Jain <[email protected]>
Signed-off-by: Riya Jain <[email protected]>
Signed-off-by: Riya Jain <[email protected]>
riyajain39
force-pushed
the
Jira-Babel-4279
branch
from
66a5d56 to
d742e44
Compare
Signed-off-by: Riya Jain <[email protected]>
rishabhtanwar29
approved these changes
Oct 10, 2023
Deepesh125
approved these changes
Oct 12, 2023
Deepesh125
merged commit b2ae5ba
into
babelfish-for-postgresql:BABEL_3_X_DEV
26 checks passed
ParikshitSarode
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 17, 2023
…olname. (babelfish-for-postgresql#1866) This commit fixes preserving the original case spelling of column names while selecting named column with a correlation name. Issue: When selecting named column with a correlation name, the lowercase name is always returned. The case of column name is not preserved. For instance, select ABC from table, here ABC is the column name. In this case column name becomes downcased. To address this issue, I've made some code modifications to ensure that the column name is handled correctly, whether it's truncated or its case needs to be preserved. Task: BABEL-4279 Signed-off-by: Riya Jain <[email protected]>
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 25, 2023
…olname. (babelfish-for-postgresql#1866) This commit fixes preserving the original case spelling of column names while selecting named column with a correlation name. Issue: When selecting named column with a correlation name, the lowercase name is always returned. The case of column name is not preserved. For instance, select ABC from table, here ABC is the column name. In this case column name becomes downcased. To address this issue, I've made some code modifications to ensure that the column name is handled correctly, whether it's truncated or its case needs to be preserved. Task: BABEL-4279 Signed-off-by: Riya Jain <[email protected]>
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 25, 2023
…olname. (babelfish-for-postgresql#1866) This commit fixes preserving the original case spelling of column names while selecting named column with a correlation name. Issue: When selecting named column with a correlation name, the lowercase name is always returned. The case of column name is not preserved. For instance, select ABC from table, here ABC is the column name. In this case column name becomes downcased. To address this issue, I've made some code modifications to ensure that the column name is handled correctly, whether it's truncated or its case needs to be preserved. Task: BABEL-4279 Signed-off-by: Riya Jain <[email protected]>
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Oct 20, 2024
…olname. (babelfish-for-postgresql#1866) This commit fixes preserving the original case spelling of column names while selecting named column with a correlation name. Issue: When selecting named column with a correlation name, the lowercase name is always returned. The case of column name is not preserved. For instance, select ABC from table, here ABC is the column name. In this case column name becomes downcased. To address this issue, I've made some code modifications to ensure that the column name is handled correctly, whether it's truncated or its case needs to be preserved. Task: BABEL-4279 Signed-off-by: Riya Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fix preserving the original case spelling of column names while selecting named column with a correlation name.
Issue:
When selecting named column with a correlation name, the lowercase spelling is always returned. The case of column name is not preserved. For instance,
select ABC from table, hereABCis the column name. In this case column name becomes downcased. To address this issue, I've made some code modifications to ensure that the column name is handled correctly, whether it's truncated or its case needs to be preserved.Issues Resolved
BABEL-4279
Signed-off-by: Riya Jain [email protected]
Test Scenarios Covered
Use case based - Added test case from original bug.
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.