Fixed error: “lost connection to parallel worker” when running parallel query #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepesh125
force-pushed
the
jira-babel-4393
branch
from
eafd6b9 to
92a3ae6
Compare
surendravishnoi
approved these changes
Oct 25, 2023
Deepesh125
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 25, 2023
…el query (babelfish-for-postgresql#1883) As per coding convention of Postgresql, One should not use elog/ereport with any level of log when error report cycle is in progress. Use of such elog may run into various error particularly when error being processed is reported from parallel worker. This may even run into crashes during cleanup. In Babelfish, we are using such elog to report log/debug without holding interrupt inside error report cycle which is leading to error like “lost connection to parallel worker”. This commit aim to fix such issue by appropriately holding/resuming interrupts during error report cycle. Task: BABEL-4393 Signed-off-by: Dipesh Dhameliya <[email protected]>
Deepesh125
added a commit
that referenced
this pull request
Oct 25, 2023
…el query (#1883) (#1953) As per coding convention of Postgresql, One should not use elog/ereport with any level of log when error report cycle is in progress. Use of such elog may run into various error particularly when error being processed is reported from parallel worker. This may even run into crashes during cleanup. In Babelfish, we are using such elog to report log/debug without holding interrupt inside error report cycle which is leading to error like “lost connection to parallel worker”. This commit aim to fix such issue by appropriately holding/resuming interrupts during error report cycle. Task: BABEL-4393 Signed-off-by: Dipesh Dhameliya <[email protected]>
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Dec 24, 2024
…el query (babelfish-for-postgresql#1883) As per coding convention of Postgresql, One should not use elog/ereport with any level of log when error report cycle is in progress. Use of such elog may run into various error particularly when error being processed is reported from parallel worker. This may even run into crashes during cleanup. In Babelfish, we are using such elog to report log/debug without holding interrupt inside error report cycle which is leading to error like “lost connection to parallel worker”. This commit aim to fix such issue by appropriately holding/resuming interrupts during error report cycle. Task: BABEL-4393 Signed-off-by: Dipesh Dhameliya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per coding convention of Postgresql, One should not use elog/ereport with any level of log when error report cycle is in progress. Use of such elog may run into various error particularly when error being processed is reported from parallel worker. This may even run into crashes during cleanup.
In Babelfish, we are using such elog to report log/debug without holding interrupt inside error report cycle which is leading to error like “lost connection to parallel worker”. This commit aim to fix such issue by appropriately holding/resuming interrupts during error report cycle.
Note on test: Given JDBC test cases are sufficient but currently parallel worker is running into other crashes or issues so we can not really show tests here. Have tested this changes locally.
Issues Resolved
Task: BABEL-4393
Signed-off-by: Dipesh Dhameliya [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.