Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DB Performance improvements #1899

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Create DB Performance improvements #1899

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0387f7
initial commit
tanscorpio7 Oct 9, 2023
d5212ae
increase time for BABEL-SP_COLUMN_PRIVILEGES
tanscorpio7 Oct 9, 2023
6c5f7d0
assert oid when fetching dbid sequence
tanscorpio7 Oct 10, 2023
1905cd7
remove sysdatabases view for each db & cache dbid seq
tanscorpio7 Oct 10, 2023
628caa0
set owner role for create view and alter table as well
tanscorpio7 Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 23 additions & 34 deletions contrib/babelfishpg_tsql/src/dbcmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@
#include "pltsql.h"
#include "extendedproperty.h"

Oid sys_babelfish_db_seq_oid = InvalidOid;

static Oid get_sys_babelfish_db_seq_oid(void);
static bool have_createdb_privilege(void);
static List *gen_createdb_subcmds(const char *schema,
const char *dbo,
Expand All @@ -57,6 +60,20 @@ static Oid do_create_bbf_db(const char *dbname, List *options, const char *owner
static void create_bbf_db_internal(const char *dbname, List *options, const char *owner, int16 dbid);
static void drop_related_bbf_namespace_entries(int16 dbid);

static Oid
get_sys_babelfish_db_seq_oid()
{
if(!OidIsValid(sys_babelfish_db_seq_oid))
{
RangeVar *sequence = makeRangeVarFromNameList(stringToQualifiedNameList("sys.babelfish_db_seq"));
Oid seqid = RangeVarGetRelid(sequence, NoLock, false);

Assert(OidIsValid(seqid));
sys_babelfish_db_seq_oid = seqid;
}
return sys_babelfish_db_seq_oid;
}

static bool
have_createdb_privilege(void)
{
Expand Down Expand Up @@ -108,21 +125,16 @@ gen_createdb_subcmds(const char *schema, const char *dbo, const char *db_owner,

appendStringInfo(&query, "CREATE SCHEMA dummy AUTHORIZATION dummy; ");

/* create sysdatabases under current DB's DBO schema */
appendStringInfo(&query, "CREATE VIEW dummy.sysdatabases AS SELECT * FROM sys.sysdatabases; ");
tanscorpio7 marked this conversation as resolved.
Show resolved Hide resolved
appendStringInfo(&query, "ALTER VIEW dummy.sysdatabases OWNER TO dummy; ");
appendStringInfo(&query, "GRANT SELECT ON dummy.sysdatabases TO dummy; ");

tanscorpio7 marked this conversation as resolved.
Show resolved Hide resolved
/* create guest schema in the database. This has to be the last statement */
if (guest)
appendStringInfo(&query, "CREATE SCHEMA dummy AUTHORIZATION dummy; ");

res = raw_parser(query.data, RAW_PARSE_DEFAULT);

if (guest)
expected_stmt_num = list_length(logins) > 0 ? 10 : 9;
expected_stmt_num = list_length(logins) > 0 ? 7 : 6;
else
expected_stmt_num = 7;
expected_stmt_num = 6;
tanscorpio7 marked this conversation as resolved.
Show resolved Hide resolved

if (list_length(res) != expected_stmt_num)
ereport(ERROR,
Expand Down Expand Up @@ -160,15 +172,6 @@ gen_createdb_subcmds(const char *schema, const char *dbo, const char *db_owner,
stmt = parsetree_nth_stmt(res, i++);
update_CreateSchemaStmt(stmt, schema, db_owner);

stmt = parsetree_nth_stmt(res, i++);
update_ViewStmt(stmt, schema);

stmt = parsetree_nth_stmt(res, i++);
update_AlterTableStmt(stmt, schema, db_owner);

stmt = parsetree_nth_stmt(res, i++);
update_GrantStmt(stmt, NULL, schema, db_owner);

if (guest)
{
stmt = parsetree_nth_stmt(res, i++);
Expand Down Expand Up @@ -306,11 +309,7 @@ getAvailDbid(void)

do
{
RangeVar *sequence = makeRangeVarFromNameList(stringToQualifiedNameList("sys.babelfish_db_seq"));
Oid seqid = RangeVarGetRelid(sequence, NoLock, false);

Assert(OidIsValid(seqid));
dbid = nextval_internal(seqid, false);
dbid = nextval_internal(get_sys_babelfish_db_seq_oid(), false);
if (start == 0)
start = dbid;
else if (start == dbid)
Expand Down Expand Up @@ -358,12 +357,8 @@ getDbidForLogicalDbRestore(Oid relid)
* dbid while inserting into sysdatabases catalog.
*/
else
{
RangeVar *sequence = makeRangeVarFromNameList(stringToQualifiedNameList("sys.babelfish_db_seq"));
Oid seqid = RangeVarGetRelid(sequence, NoLock, false);
dbid = DirectFunctionCall1(currval_oid, get_sys_babelfish_db_seq_oid());

dbid = DirectFunctionCall1(currval_oid, seqid);
}
bbf_set_current_user(prev_current_user);

return dbid;
Expand Down Expand Up @@ -416,7 +411,6 @@ create_bbf_db_internal(const char *dbname, List *options, const char *owner, int
const char *prev_current_user;
int stmt_number = 0;
int save_sec_context;
int save_nestlevel;
bool is_set_userid;
Oid save_userid;

Expand Down Expand Up @@ -539,7 +533,6 @@ create_bbf_db_internal(const char *dbname, List *options, const char *owner, int
GetUserIdAndSecContext(&save_userid, &save_sec_context);
SetUserIdAndSecContext(get_role_oid(dbo_role, true),
save_sec_context | SECURITY_LOCAL_USERID_CHANGE);
save_nestlevel = NewGUCNestLevel();
is_set_userid = true;
}
/* need to make a wrapper PlannedStmt */
Expand All @@ -565,10 +558,8 @@ create_bbf_db_internal(const char *dbname, List *options, const char *owner, int
NULL);

if(is_set_userid)
{
AtEOXact_GUC(false, save_nestlevel);
SetUserIdAndSecContext(save_userid, save_sec_context);
}

CommandCounterIncrement();
}
set_cur_db(old_dbid, old_dbname);
Expand All @@ -591,10 +582,8 @@ create_bbf_db_internal(const char *dbname, List *options, const char *owner, int
PG_CATCH();
{
if(is_set_userid)
{
AtEOXact_GUC(false, save_nestlevel);
SetUserIdAndSecContext(save_userid, save_sec_context);
}

/* Clean up. Restore previous state. */
bbf_set_current_user(prev_current_user);
set_cur_db(old_dbid, old_dbname);
Expand Down