-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplemented sys.babelfish_concat_wrapper in C to improve the performance #1911
Merged
Deepesh125
merged 27 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:Babel-4299
Oct 20, 2023
Merged
Reimplemented sys.babelfish_concat_wrapper in C to improve the performance #1911
Deepesh125
merged 27 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:Babel-4299
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, please adjust the tab for the if conditions
Deepesh125
reviewed
Oct 13, 2023
Deepesh125
approved these changes
Oct 20, 2023
Deepesh125
changed the title
Babel 4299
Reimplemented sys.babelfish_concat_wrapper in C to improve the performance
Oct 20, 2023
Deepesh125
merged commit Oct 20, 2023
1f5e81e
into
babelfish-for-postgresql:BABEL_3_X_DEV
27 checks passed
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Oct 27, 2024
…mance (babelfish-for-postgresql#1911) The '+' operator it took more time to complete the query for concatenation operation which was due to the function babelfish_concat_wrapper was implemented in SQL. In this change, the babelfish_concat_wrapper function is implemented in C. This improves the '+' operator query execution time by 55% Task: BABEL-4299 Signed-off-by: Parikshit Sarode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - Reimplemented sys.babelfish_concat_wrapper in C to improve the performance
Signed-off-by: Parikshit Sarode [email protected]
Issues Resolved
Task: BABEL-4299
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.