Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented sys.babelfish_concat_wrapper in C to improve the performance #1911

Merged

Conversation

ParikshitSarode
Copy link
Contributor

@ParikshitSarode ParikshitSarode commented Oct 11, 2023

Description - Reimplemented sys.babelfish_concat_wrapper in C to improve the performance

  1. The '+' operator it took more time to complete the query for concatenation operation.
  2. This was due to the function babelfish_concat_wrapper was implemented in SQL.
  3. In this change, the babelfish_concat_wrapper function is implemented in C.
  4. This improves the '+' operator query execution time by 55%

Signed-off-by: Parikshit Sarode [email protected]

Issues Resolved

Task: BABEL-4299

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@forestkeeper forestkeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, please adjust the tab for the if conditions

@Deepesh125 Deepesh125 changed the title Babel 4299 Reimplemented sys.babelfish_concat_wrapper in C to improve the performance Oct 20, 2023
@Deepesh125 Deepesh125 merged commit 1f5e81e into babelfish-for-postgresql:BABEL_3_X_DEV Oct 20, 2023
27 checks passed
staticlibs pushed a commit to wiltondb/babelfish_extensions that referenced this pull request Oct 27, 2024
…mance (babelfish-for-postgresql#1911)

The '+' operator it took more time to complete the query for concatenation operation which was due to the function babelfish_concat_wrapper was implemented in SQL. In this change, the babelfish_concat_wrapper function is implemented in C. This improves the '+' operator query execution time by 55%

Task: BABEL-4299
Signed-off-by: Parikshit Sarode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants