Another batch of memory management improvement #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejaokri
force-pushed
the
klejao-babel-valgrind-3x
branch
2 times, most recently
from
a165efe to
c9890a8
Compare
Some codepaths access arrays out of bounds or reference uninitialize variables. do_compile() prepare_format_string() pre_transform_target_entry() bbf_ProcessUtility() babelfish_add_domain_mapping_entry_internal() object_name() TdsSendTypeBinary() modify_insert_stmt() Tasks: BABEL-4446, BABEL-4457, BABEL-4456, BABEL-4471, BABEL-4472, BABEL-4483 Signed-off-by: Kristian Lejao <[email protected]>
lejaokri
force-pushed
the
klejao-babel-valgrind-3x
branch
from
c9890a8 to
6a54a9c
Compare
surendravishnoi
approved these changes
Oct 18, 2023
2jungkook
approved these changes
Oct 18, 2023
2jungkook
merged commit 817b371
into
babelfish-for-postgresql:BABEL_3_X_DEV
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some codepaths access arrays out of bounds or reference uninitialize variables.
do_compile()
prepare_format_string()
pre_transform_target_entry()
bbf_ProcessUtility()
babelfish_add_domain_mapping_entry_internal()
object_name()
TdsSendTypeBinary()
modify_insert_stmt()
Tasks: BABEL-4446, BABEL-4457, BABEL-4456, BABEL-4471, BABEL-4472, BABEL-4483
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.