Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in pgstat_init_function_usage #1935

Conversation

ParikshitSarode
Copy link
Contributor

@ParikshitSarode ParikshitSarode commented Oct 19, 2023

Description - Crash in pgstat_init_function_usage

  1. Crash in pgstat_init_function_usage_wrapper due to the ReleaseSysCache is being called even if proctup is Invalid
  2. ReleaseSysCache on proctup is only called when proctup is validated by HeapTupleIsValid

Signed-off-by: Parikshit Sarode [email protected]

Issues Resolved

Task: BABEL-4466

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ParikshitSarode ParikshitSarode requested review from KushaalShroff, Deepesh125 and shalinilohia50 and removed request for KushaalShroff October 19, 2023 08:47
@shalinilohia50
Copy link
Contributor

Please update the PR description from Jira babel 4466 to Fix crash in pgstat_init_function_usage

@ParikshitSarode ParikshitSarode changed the title Jira babel 4466 Fix crash in pgstat_init_function_usage Oct 20, 2023
@Deepesh125 Deepesh125 merged commit f9734a3 into babelfish-for-postgresql:BABEL_3_X_DEV Oct 20, 2023
27 checks passed
@Deepesh125 Deepesh125 deleted the Jira-Babel-4466 branch October 20, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants