Fix the issue of preserving case of column names in SELECT corrname.colname and Fix the issue of preserving case of column names in SELECT corrname.colname. #1941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fix preserving the original case spelling of column names while selecting named column with a correlation name. It also fix the crash is pre_transform_target_entry for queries that involves DELETE ... OUTPUT with JOIN statement.
Issue 1:
When selecting named column with a correlation name, the lowercase spelling is always returned. The case of column name is not preserved. For instance,
select ABC from table
, here ABC is the column name. In this case column name becomes downcased. To address this issue, I've made some code modifications to ensure that the column name is handled correctly, whether it's truncated or its case needs to be preserved.Issue 2:
For the delete queries with join statement, somehow the
res->location
is not processed correctly. This causes server to crash as the value oflast_dot
pointer has never been computed. I implemented a check which first computed whether theres->location
is correct or not and then further proceed with the code.Issues Resolved
BABEL-4279
BABEL-4484
Signed-off-by: Riya Jain [email protected]
Test Scenarios Covered
Use case based - Added test case from original bug.
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.