Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of preserving case of column names in SELECT corrname.colname and Fix the issue of preserving case of column names in SELECT corrname.colname. #1941

Conversation

riyajain39
Copy link
Contributor

@riyajain39 riyajain39 commented Oct 20, 2023

Description

This pull request fix preserving the original case spelling of column names while selecting named column with a correlation name. It also fix the crash is pre_transform_target_entry for queries that involves DELETE ... OUTPUT with JOIN statement.

Issue 1:
When selecting named column with a correlation name, the lowercase spelling is always returned. The case of column name is not preserved. For instance, select ABC from table, here ABC is the column name. In this case column name becomes downcased. To address this issue, I've made some code modifications to ensure that the column name is handled correctly, whether it's truncated or its case needs to be preserved.

Issue 2:
For the delete queries with join statement, somehow the res->location is not processed correctly. This causes server to crash as the value of last_dot pointer has never been computed. I implemented a check which first computed whether the res->location is correct or not and then further proceed with the code.

Issues Resolved

BABEL-4279
BABEL-4484

Signed-off-by: Riya Jain [email protected]

Test Scenarios Covered

  • Use case based - Added test case from original bug.

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@riyajain39 riyajain39 requested a review from Deepesh125 October 20, 2023 12:10
@forestkeeper
Copy link
Contributor

Please add me as request for this PR when ready

Riya Jain added 2 commits October 25, 2023 08:37
@riyajain39 riyajain39 force-pushed the Jira-babel-4484-14-latest branch from 03655f9 to 9110cdd Compare October 25, 2023 08:38
Signed-off-by: Riya Jain <[email protected]>
@Deepesh125 Deepesh125 merged commit 3b93f27 into babelfish-for-postgresql:BABEL_2_X_DEV Oct 26, 2023
@Deepesh125 Deepesh125 deleted the Jira-babel-4484-14-latest branch October 26, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants