Added 'sa' login equivalent 'jdbc_user' login for non-sysadmin login in server_princiapls #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in server_princiapls view. Signed-off-by: ANJU BHARTI <[email protected]>
anju15bharti
requested review from
HarshLunagariya,
shardgupta and
shalinilohia50
shalinilohia50
suggested changes
Oct 24, 2023
| @@ -326,6 +326,7 @@ CAST(CASE WHEN Ext.type = 'R' THEN 1 ELSE Ext.is_fixed_role END AS sys.BIT) AS i | |||
| FROM pg_catalog.pg_roles AS Base INNER JOIN sys.babelfish_authid_login_ext AS Ext ON Base.rolname = Ext.rolname | |||
| WHERE pg_has_role(suser_id(), 'sysadmin'::TEXT, 'MEMBER') | |||
| OR Ext.orig_loginname = suser_name() | |||
| OR Ext.orig_loginname = 'jdbc_user' | |||
There was a problem hiding this comment.
loginname is not necessarily jdbc_user always. We have created this role in init.sh, it could be anything else provided by the customer.
Please don't hardcode this value.
HarshLunagariya
suggested changes
Oct 25, 2023
| @@ -326,6 +326,7 @@ CAST(CASE WHEN Ext.type = 'R' THEN 1 ELSE Ext.is_fixed_role END AS sys.BIT) AS i | |||
| FROM pg_catalog.pg_roles AS Base INNER JOIN sys.babelfish_authid_login_ext AS Ext ON Base.rolname = Ext.rolname | |||
| WHERE pg_has_role(suser_id(), 'sysadmin'::TEXT, 'MEMBER') | |||
| OR Ext.orig_loginname = suser_name() | |||
| OR Ext.orig_loginname = 'jdbc_user' | |||
1 task
Signed-off-by: ANJU BHARTI <[email protected]>
shalinilohia50
approved these changes
Oct 25, 2023
test/JDBC/upgrade/13_6/schedule
Outdated
| @@ -233,7 +233,7 @@ sys-schema-name | |||
| sys-schemas | |||
| sys-schemas-dep | |||
| sys-selective_xml_index_paths | |||
| sys-server_principals | |||
| sys-server_principals_before-15_5 | |||
There was a problem hiding this comment.
Name is incorrect, so the tests are failing.
It should be sys-server_principals-before-15_5
Signed-off-by: ANJU BHARTI <[email protected]>
anju15bharti
force-pushed
the
JIRA-BABEL-4361-new
branch
from
9c135de to
74dd54b
Compare
added 2 commits
October 25, 2023 16:17
This reverts commit 74dd54b.
Signed-off-by: ANJU BHARTI <[email protected]>
shalinilohia50
approved these changes
Oct 26, 2023
HarshLunagariya
approved these changes
Oct 26, 2023
shardgupta
approved these changes
Oct 26, 2023
shardgupta
merged commit b919797
into
babelfish-for-postgresql:BABEL_3_X_DEV
27 checks passed
anju15bharti
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 6, 2023
…in server_princiapls (babelfish-for-postgresql#1948) sys.server_principals view was returning only the rows for current login and fixed_server_role(sysadmin). Added 'sa' SQL_LOGIN sql server equivalent babelfish 'jdbc_user' SQL_LOGIN for non-sysadmin login in server_princiapls Task: BABEL-4361 (add on) Signed-off-by: Anju Bharti [email protected]
anju15bharti
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 6, 2023
…in server_princiapls (babelfish-for-postgresql#1948) sys.server_principals view was returning only the rows for current login and fixed_server_role(sysadmin). Added 'sa' SQL_LOGIN sql server equivalent babelfish 'jdbc_user' SQL_LOGIN for non-sysadmin login in server_princiapls Task: BABEL-4361 (add on) Signed-off-by: Anju Bharti [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sys.server_principals view was returning only the rows for current login and fixed_server_role(sysadmin).
Added 'sa' SQL_LOGIN sql server equivalent babelfish 'jdbc_user' SQL_LOGIN for non-sysadmin login in server_princiapls
Task: BABEL-4361 (add on)
Authored-by: Anju Bharti [email protected]
Signed-off-by: Anju Bharti [email protected]
Issues Resolved
JIRA BABEL-4361 (add on)
sys.server_principals view was returning only the rows for current login and fixed_server_role(sysadmin).
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.