Support default as params for function and procedure #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestkeeper
changed the title
Previously when we call functions/procedures, we don't support default keyword usage like : select foofunc(default); or exec fooproc default This commit support to use default keyword as function or procedure param when the default value is previously defined in create proc/func Task: BABEL-335 Signed-off-by: Zhibai Song <[email protected]>
forestkeeper
force-pushed
the
babel-335
branch
from
312c42e to
c36d405
Compare
forestkeeper
changed the title
lejaokri
reviewed
Oct 27, 2023
There was a problem hiding this comment.
I am hitting the following when I try to compile manually
/usr/bin/install: will not overwrite just-created ‘/local/home/klejao/pg15/postgres/share/extension/babelfishpg_common--3.2.0--3.3.0.sql’ with ‘sql/babelfishpg_common--3.2.0--3.3.0.sql’
make: *** [install] Error 1
lejaokri
approved these changes
Oct 27, 2023
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Jun 25, 2024
…postgresql#1955) Previously when we call functions/procedures, we don't support default keyword usage like : select foofunc(default); or exec fooproc default This commit support to use default keyword as function or procedure param when the default value is previously defined in create proc/func Task: BABEL-335 Signed-off-by: Zhibai Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we call functions/procedures, we don't support default keyword usage like :
select foofunc(default);
or
exec fooproc default
This commit support to use default keyword as function or procedure param when the default value is previously defined in create proc/func
Engine pr : babelfish-for-postgresql/postgresql_modified_for_babelfish#242
Task: BABEL-335
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.