Crash in Table Variable lookup after TVP execution via TDS RPC SPExecuteSQL #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KushaalShroff
force-pushed
the
fix_tvp_babel_jira_4463
branch
from
3c29d1f to
139ac2a
Compare
KushaalShroff
force-pushed
the
fix_tvp_babel_jira_4463
branch
from
139ac2a to
cc27288
Compare
KushaalShroff
changed the title
Deepesh125
approved these changes
Nov 2, 2023
KushaalShroff
merged commit a3ce1e4
into
babelfish-for-postgresql:BABEL_3_X_DEV
27 checks passed
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 3, 2023
…uteSQL (babelfish-for-postgresql#1963) Earlier we were not reseting the tvp_lookup_list to NIL in SPExecuteSQL after usage and freeing it because of which any subsequent Table Variable lookup would try to lookup in this list which was freed and lead to a crash. To fix this we set tvp_lookup_list as NIL at the start and at the end of SPExecuteSQL TDS RPC function. Issues Resolved BABEL-4463 --signed-off-by: Kushaal Shroff <[email protected]>
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Dec 24, 2024
…uteSQL (babelfish-for-postgresql#1963) Earlier we were not reseting the tvp_lookup_list to NIL in SPExecuteSQL after usage and freeing it because of which any subsequent Table Variable lookup would try to lookup in this list which was freed and lead to a crash. To fix this we set tvp_lookup_list as NIL at the start and at the end of SPExecuteSQL TDS RPC function. Issues Resolved BABEL-4463 --signed-off-by: Kushaal Shroff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier we were not reseting the tvp_lookup_list to NIL in SPExecuteSQL after usage and freeing it because of which any subsequent Table Variable lookup would try to lookup in this list which was freed and lead to a crash.
To fix this we set tvp_lookup_list as NIL at the start and at the end of SPExecuteSQL TDS RPC function.
Issues Resolved
BABEL-4463
--signed-off-by: Kushaal Shroff [email protected]
Test Scenarios Covered
Use case based -
X
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.