Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix bugs for GRANT/REVOKE on SCHEMA (#2031)" #2051

Conversation

shalinilohia50
Copy link
Contributor

This reverts commit dd23da9.

Description

[Describe what this change achieves - Guidelines below (please delete the guidelines after writing the PR description)]

  1. What is the change? This is best described in terms of “Currently, Babelfish does X. With this change it now does Y.” Think of “What did it used to do?” and “What does it do now?”
  1. Why was the change made? What drove our desire to put effort into the change?
  2. How was the code changed should only appear for large commits. This can serve as a rough roadmap to what’s contained in the commit. It should be very high level; if it’s directly referencing code it’s probably too detailed. It’s also critical that this section of a commit message does not try to replace proper code documentation (ie, block comments or README files). Generally, this section should only appear if the commit itself is large enough that it’s helpful to provide a roadmap to someone looking at the commit.
  3. The last descriptive piece is the “title” for the commit: the very first line of the commit message, which should typically be less than 80 characters. A good title is critical, because it’s the only thing that shows up in places like the Github commit listing. No one’s got time to read through full commit messages when trying to find a single commit out of dozens.

Issues Resolved

[List any issues this PR will resolve]

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@forestkeeper forestkeeper merged commit 0cabf83 into babelfish-for-postgresql:BABEL_3_X_DEV Nov 22, 2023
29 checks passed
@shalinilohia50 shalinilohia50 deleted the revoke-bug-fixes branch November 22, 2023 05:13
Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 21, 2023
Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 24, 2023
Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 24, 2023
Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 24, 2023
Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 28, 2023
Sairakan pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 28, 2023
priyansx pushed a commit that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants