Fix bugs for CREATE FULLTEXT INDEX logic for supporting unique index creation via primary key during table creation (#2067) BABEL_3_4_STABLE #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
primary key index cases, updated test cases
HarshLunagariya
approved these changes
Nov 28, 2023
kuntalghosh
merged commit 396b92a
into
babelfish-for-postgresql:BABEL_3_4_STABLE
28 checks passed
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 28, 2023
This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 28, 2023
This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
1 task
jsudrik
pushed a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 21, 2023
… (babelfish-for-postgresql#2067) This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 21, 2023
… (babelfish-for-postgresql#2067) This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
… (babelfish-for-postgresql#2067) This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
… (babelfish-for-postgresql#2067) This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
… (babelfish-for-postgresql#2067) This commit fixes an issue when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing. CREATE TABLE tableName(ID INT NOT NULL CONSTRAINT indexName PRIMARY KEY, txt TEXT); CREATE FULLTEXT INDEX ON tableName(txt) KEY INDEX indexName; GO This was failing because we were only checking for a hashed unique index name not a simple index name during fulltext index creation and hence getting exception. Issues Resolved JIRA: BABEL-4383 Signed-off-by: Roshan Kanwar [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit resolved the bug that was found when we execute the following query to create a unique index during table creation and when we use that index name for fulltext index creation, it was failing.
Need this in stable first because tests in #2067 were failing and we can't merge that pr directly as other PRs will fail too.
This was failing because of the unique index check logic in
exec_stmt_fulltextindex. Added an extra check in the if clause for handling this.Issues Resolved
JIRA: BABEL-4383
Signed-off-by: Roshan Kanwar [email protected]
Test Scenarios Covered
Use case based - Added
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.