-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the custom fts parser guc and update test cases #2074
Merged
jsudrik
merged 1 commit into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:bug-fixes-4379
Nov 28, 2023
Merged
Disable the custom fts parser guc and update test cases #2074
jsudrik
merged 1 commit into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:bug-fixes-4379
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update test cases and output files
shalinilohia50
approved these changes
Nov 28, 2023
jsudrik
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical change already merged in stable. Approved.
jsudrik
merged commit Nov 28, 2023
a850f86
into
babelfish-for-postgresql:BABEL_3_X_DEV
29 checks passed
roshan0708
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 28, 2023
…ql#2074) update test cases and output files
1 task
jsudrik
pushed a commit
that referenced
this pull request
Nov 28, 2023
Need this for disabling the custom fts parser guc so that feature is enabled. Task: BABEL-4379 Signed-off-by: Roshan Kanwar [email protected]
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 21, 2023
…ql#2074) update test cases and output files
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 21, 2023
…ql#2074) update test cases and output files
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…ql#2074) update test cases and output files
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…ql#2074) update test cases and output files
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…ql#2074) update test cases and output files
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 28, 2023
…ql#2074) update test cases and output files
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 28, 2023
…ql#2074) update test cases and output files
priyansx
pushed a commit
that referenced
this pull request
Dec 29, 2023
update test cases and output files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commits turns the custom fts parser on by default which was initially planned to be off. Also updated jdbc test files for the same.
Issues Resolved
JIRA: BABEL-4379
Signed-off-by: Roshan Kanwar [email protected]
Test Scenarios Covered
Use case based - Added
Boundary conditions - Added
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.