Fix valgrind warnings related to varcharvarbinary function

[basasairohan]

Description

Currently, we have defined the following cast functions which call varcharvarbinary C function with only 1 argument. But, in varcharvarbinary function, we are reading two arguments which might lead to memory related issues.

1. sys.binarysysvarchar
2. sys.binaryvarchar
3. sys.rowversionsysvarchar
4. sys.rowversionvarchar

This change modifies the above casts to have 3 arguments, one for input, one for typmod (integer) and the other for specifying isExplicit (boolean)

Issues Resolved

BABEL-4475
Signed-off-by: Sai Rohan Basa [email protected]

Test Scenarios Covered

• Use case based - Tests related to above cast functions have already been written in babel_datatype.sql and BABEL-ROWVERSION.sql

• Boundary conditions - N/A

• Arbitrary inputs - N/A

• Negative test cases - N/A

• Minor version upgrade tests - N/A

• Major version upgrade tests - N/A

• Performance tests - N/A

• Tooling impact - N/A

• Client tests - N/A

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Deepesh125]

Lets have some test cases which uses these cast in prepare script and then we try to upgrade it,

Prepare:

create view some_view as select cast(cast(some_value as binary) as varchar)

verify --

extract the view definition, SELECT pg_catalog.pg_get_viewdef(oid, true) FROM pg_class WHERE relname = 'some_view';