Support whitespace character for <simple_term>, fix bugs in translation logic and improve error handling related to Full-Text Search #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on logic and improve error handling related to Full-Text Search Currently for full-text search, babelfish throws syntax error for usage of whitespace characters. This commit implements the logic to support the usage of whitespace characters as well as improves the error handling for unsupported languages and special characters for fulltext search conditions and also some minor code cleanups and bug fixes. Task: BABEL-4645 Signed-off-by: Roshan Kanwar <[email protected]>
Sairakan
approved these changes
Dec 26, 2023
shalinilohia50
approved these changes
Dec 27, 2023
jsudrik
approved these changes
Dec 27, 2023
jsudrik
merged commit b913695
into
babelfish-for-postgresql:BABEL_3_X_DEV
30 checks passed
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 28, 2023
…on logic and improve error handling related to Full-Text Search (babelfish-for-postgresql#2163) Currently for full-text search, babelfish throws syntax error for usage of whitespace characters. This commit implements the logic to support the usage of whitespace characters as well as improves the error handling for unsupported languages and special characters for fulltext search conditions and also some minor code cleanups and bug fixes. Task: BABEL-4645 Signed-off-by: Roshan Kanwar <[email protected]> * fixed validation output file * Updated generic error message for special characters and other languages
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 28, 2023
…on logic and improve error handling related to Full-Text Search (babelfish-for-postgresql#2163) Currently for full-text search, babelfish throws syntax error for usage of whitespace characters. This commit implements the logic to support the usage of whitespace characters as well as improves the error handling for unsupported languages and special characters for fulltext search conditions and also some minor code cleanups and bug fixes. Task: BABEL-4645 Signed-off-by: Roshan Kanwar <[email protected]> * fixed validation output file * Updated generic error message for special characters and other languages
priyansx
pushed a commit
that referenced
this pull request
Dec 29, 2023
…on logic and improve error handling related to Full-Text Search (#2163) Currently for full-text search, babelfish throws syntax error for usage of whitespace characters. This commit implements the logic to support the usage of whitespace characters as well as improves the error handling for unsupported languages and special characters for fulltext search conditions and also some minor code cleanups and bug fixes. Task: BABEL-4645 Signed-off-by: Roshan Kanwar <[email protected]> * fixed validation output file * Updated generic error message for special characters and other languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently for full-text search, babelfish throws syntax error for usage of whitespace characters. This commit implements the logic to support the usage of whitespace characters as well as improves the error handling for unsupported languages and special characters for fulltext search conditions and also some minor code cleanups and bug fixes. Also added corresponding test cases.
Signed-off-by: Roshan Kanwar [email protected]
Issues Resolved
Task: BABEL-4645
Test Scenarios Covered
Use case based - added
Boundary conditions - added
Arbitrary inputs -
Negative test cases - added
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.