Reimplement datepart function to improve the performance #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 470e0db.
This reverts commit 4b85c4b.
PR implements fix for low performance with function sys. datepart_internal by re-implement in C Signed-off-by: Parikshit Sarode <[email protected]> Co-authored-by: Parikshit Sarode <[email protected]>
ParikshitSarode
changed the title
Deepesh125
changed the title
Deepesh125
approved these changes
Jan 3, 2024
Deepesh125
merged commit 5d80c2a
into
babelfish-for-postgresql:BABEL_2_X_DEV
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - Low performance with function sys. datepart_internal -- re-implement in
CSigned-off-by: Parikshit Sarode [email protected]
Issues Resolved
Task: BABEL-4302,BABEL-979, BABEL-4366 issues related to datepart, BABEL-4582 issues related to datepart and not cast
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.