Support PRINT NULL and PRINT <empty string> #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sairakan
approved these changes
Jan 3, 2024
jsudrik
approved these changes
Jan 4, 2024
jsudrik
merged commit 0e1721a
into
babelfish-for-postgresql:BABEL_3_X_DEV
30 checks passed
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…#2199) This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
shardgupta
pushed a commit
that referenced
this pull request
Jan 9, 2024
This PR introduces support for printing NULL and <empty string>. When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints <NULL> and an empty string, respectively. Signed-off-by: Rob Verschoor [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the argument to PRINT is NULL or an empty string, a single space should be printed. However Babelfish currently prints
<NULL>and an empty string, respectively.Signed-off-by: Rob Verschoor [email protected]
Issues Resolved
BABEL-4005 PRINT NULL prints a string but should print NULL
Test Scenarios Covered
Use case based - Yes
Boundary conditions - N/A
Arbitrary inputs - N/A
Negative test cases - N/A
Minor version upgrade tests - N/A
Major version upgrade tests - N/A
Performance tests - N/A
Tooling impact - N/A
Client tests - N/A
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.