Remove pltsql_call_handler from sys.all_objects #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 3, 2024 01:24
We have fixed duplicate OIDs for most objects, however, `pltsql_call_handler` still has a possibility of duplicate OIDs after MVU to PG14/15/16 because `GetNewObjectId_hook()` is not called when we restore the first C function. This commit removes pltsql_call_handler from sys.all_objects, hence sys.all_objects won't have duplicate OIDs after major version upgrades. Task: BABEL-4662
contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--3.4.0--3.5.0.sql
Outdated
Show resolved
Hide resolved
rishabhtanwar29
approved these changes
Jan 3, 2024
Sairakan
approved these changes
Jan 3, 2024
forestkeeper
approved these changes
Jan 3, 2024
2jungkook
merged commit ef84a49
into
babelfish-for-postgresql:BABEL_4_X_DEV
28 checks passed
2jungkook
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 3, 2024
…esql#2201) We have fixed duplicate OIDs for most objects, however, `pltsql_call_handler` still has a possibility of duplicate OIDs after MVU to PG14/15/16 because `GetNewObjectId_hook()` is not called when we restore the first C function. This commit removes pltsql_call_handler from sys.all_objects, hence sys.all_objects won't have duplicate OIDs after major version upgrades. Task: BABEL-4662 Co-authored-by: Jungkook Lee <[email protected]>
2jungkook
added a commit
that referenced
this pull request
Jan 3, 2024
We have fixed duplicate OIDs for most objects, however, `pltsql_call_handler` still has a possibility of duplicate OIDs after MVU to PG14/15/16 because `GetNewObjectId_hook()` is not called when we restore the first C function. This commit removes pltsql_call_handler from sys.all_objects, hence sys.all_objects won't have duplicate OIDs after major version upgrades. (This is a cherry-pick from ef84a49 except .github/scripts/clone_engine_repo.conf) Task: BABEL-4662 Signed-off-by: Jungkook Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have fixed duplicate OIDs for most objects, however,
pltsql_call_handlerstill has a possibility of duplicate OIDs after MVU to PG14/15/16 becauseGetNewObjectId_hook()is not called when we restore the first C function.This commit removes pltsql_call_handler from sys.all_objects, hence sys.all_objects won't have duplicate OIDs after major version upgrades.
Task: BABEL-4662
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.