Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed blankspace padding in char datatype for multibyte characters #2225

Conversation

rohit01010
Copy link
Contributor

Description

Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue.

Tested locally

-- with server collation name = japanese_ci_as
1> select CONCAT(CAST('£' as char(1)), '|')
2> go
concat                                                                                                                                                                                                                                                          
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 |                                                                                                                                                                                                                                                              

(1 rows affected)

-- with server collation name = chinese_prc_ci_as
1> select CONCAT(CAST('ち' AS char(1)),'|');
2> go
concat                                                                                                                                                                                                                                                          
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 |                                                                                                                                                                                                                                                              

(1 rows affected)

Cherry-picked from: PR-2167
Signed-off-by: Rohit Bhagat [email protected]

Issues Resolved

BABEL-4638

Test Scenarios Covered

  • Use case based - YES

  • Boundary conditions - NA

  • Arbitrary inputs - NA

  • Negative test cases - NA

  • Minor version upgrade tests - NA

  • Major version upgrade tests - NA

  • Performance tests - NA

  • Tooling impact - NA

  • Client tests - NA

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…abelfish-for-postgresql#2167)

Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue.

Task: BABEL-4638
Signed-off-by: Rohit Bhagat <[email protected]>
@rohit01010 rohit01010 requested a review from Deepesh125 January 8, 2024 10:37
@rohit01010
Copy link
Contributor Author

Already cherry-picked in BABEL_4_X_DEV along with other commits.

@rohit01010 rohit01010 closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant