Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG-Vector support in Babelfish #2232

Conversation

KushaalShroff
Copy link
Contributor

@KushaalShroff KushaalShroff commented Jan 9, 2024

Description

With GenAI capturing the imagination and Vector Similarity search being one of the foundational features in this space, we MUST leverage what is being offered by pgvector and make it available for T-SQL applications.
With this commit, users can install the vector extension in SYS schema and start using not only the datatype but also all of the other features available in pgvector extension [https://github.com/pgvector/pgvector].
NOTE: Except for Creation of IVFFLAT and HNSW indexes, rest all queries must follow TSQL syntax and semantics.

TASK: BABEL-4687
Signed-off-by: Kushaal Shroff [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2024

Pull Request Test Coverage Report for Build 7636388945

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 72.464%

Totals Coverage Status
Change from base Build 7589172844: 0.03%
Covered Lines: 40146
Relevant Lines: 55401

💛 - Coveralls

@Deepesh125
Copy link
Contributor

2 general questions:

  1. Do we need to do anything additional on the top of existing DROP INDEX to support dropping these indexes?
  2. What would happen if we try to create indexes with different strategy (HNSW and IVFFLAT) on same columns?

Deepesh125
Deepesh125 previously approved these changes Jan 24, 2024
@KushaalShroff KushaalShroff merged commit 5d7b982 into babelfish-for-postgresql:BABEL_3_X_DEV Jan 29, 2024
37 checks passed
@KushaalShroff KushaalShroff deleted the vector_support branch January 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants