Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should set pltsql_implicit_transactions = false as default #2250

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Should set pltsql_implicit_transactions = false as default #2250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions contrib/babelfishpg_tsql/src/guc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ bool pltsql_allow_windows_login = true;
bool pltsql_allow_fulltext_parser = false;

bool pltsql_xact_abort = false;
bool pltsql_implicit_transactions = true;
bool pltsql_implicit_transactions = false;
bool pltsql_cursor_close_on_commit = false;
bool pltsql_disable_batch_auto_commit = false;
bool pltsql_disable_internal_savepoint = false;
Expand Down Expand Up @@ -880,11 +880,15 @@ define_custom_variables(void)
GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE | GUC_DISALLOW_IN_AUTO_FILE,
NULL, NULL, NULL);

pltsql_implicit_transactions = false;
// define babelfishpg_tsql.ansi_defaults will set pltsql_implicit_transactions = true
// that's not expected during initialize, set to false as the same for default

DefineCustomBoolVariable("babelfishpg_tsql.implicit_transactions",
gettext_noop("enable implicit transactions"),
NULL,
&pltsql_implicit_transactions,
true,
false,
PGC_USERSET,
GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE | GUC_DISALLOW_IN_AUTO_FILE,
NULL, NULL, NULL);
Expand Down
Loading