Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum to avoid strcmp for better performance in TdsSetAtAtStatVariable which is in critical path for many operations. #2254

Closed
wants to merge 1 commit into from

Conversation

jsudrik
Copy link
Contributor

@jsudrik jsudrik commented Jan 16, 2024

Description

Changed the function TdsSetAtAtStatVariable() to use integer comparison with enum instead of string comparison. This is for improved performance since this function is called very often.

Tests are yet to be added.

Signed-off-by: Jay Sudrik [email protected]

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jsudrik jsudrik requested a review from kuntalghosh January 16, 2024 15:19
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7543720537

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 72.323%

Totals Coverage Status
Change from base Build 7524419593: 0.002%
Covered Lines: 39756
Relevant Lines: 54970

💛 - Coveralls

@jsudrik jsudrik closed this Jan 17, 2024
@kuntalghosh kuntalghosh deleted the BABEL-3799 branch July 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants