OID Wraparound #2259
Merged
OID Wraparound #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Chang <[email protected]> Remove stress test due to timeout Support full OID range Make GUC unalterable for now blank commit empty Add null check in logical schema Remove unnecessary volatile blank Adding some simple unit testing Signed-off-by: Tim Chang <[email protected]> Added tests to upgrade Signed-off-by: Tim Chang <[email protected]> Added new JDBC tests for temp tables Moved new OID generation functions into extension hooks Signed-off-by: Tim Chang <[email protected]> Added extra tests for buffer Signed-off-by: Tim Chang <[email protected]> Minor fixes Signed-off-by: Tim Chang <[email protected]> Rerun tests Bump SLA Signed-off-by: Tim Chang <[email protected]> Add invariant checks in functions, added unit tests, expanded JDBC tests Signed-off-by: Tim Chang <[email protected]> Minor test changes, comments
Pull Request Test Coverage Report for Build 7562576856
💛 - Coveralls |
lejaokri
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
@timchang514 confirmed @surendravishnoi has approved the original PRs:
extension: #1894
engine: babelfish-for-postgresql/postgresql_modified_for_babelfish#232
lejaokri
merged commit f43add5
into
babelfish-for-postgresql:BABEL_4_X_DEV
31 checks passed
1 task
forestkeeper
pushed a commit
that referenced
this pull request
Jan 25, 2024
Adding toasts to ENR for temp tables. This was originally introduced as part of #2259 . Signed-off-by: Tim Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a separate OID buffer for temp objects. Since temp objects are already session-local, we can allocate a separate buffer of OIDs set aside only for temp objects. This same buffer range can be used across all sessions.
Test Scenarios Covered
Unit tests in
babelfishpg_unitfor testing of individual functions. Standard JDBC tests for temp tables. In addition, a new JDBC module written that helps us test specific temp-table cases and inspecting OIDs of generated tables, among other things.Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.