Remove pltsql_call_handler from sys.all_objects #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have fixed duplicate OIDs for most objects, however, `pltsql_call_handler` still has a possibility of duplicate OIDs after MVU to PG14/15/16 because `GetNewObjectId_hook()` is not called when we restore the first C function. This commit removes pltsql_call_handler from sys.all_objects, hence sys.all_objects won't have duplicate OIDs after major version upgrades. Task: BABEL-4662 Signed-off-by: Jungkook Lee <[email protected]>
forestkeeper
approved these changes
Jan 18, 2024
2jungkook
merged commit 783f3db
into
babelfish-for-postgresql:BABEL_2_X_DEV
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have fixed duplicate OIDs for most objects, however,
pltsql_call_handlerstill has a possibility of duplicate OIDs after MVU to PG14/15/16 becauseGetNewObjectId_hook()is not called when we restore the first C function.This commit removes pltsql_call_handler from sys.all_objects, hence sys.all_objects won't have duplicate OIDs after major version upgrades.
(This is a cherry-pick from ef84a49 except upgrade scripts and dev/github actions.)
Task: BABEL-4662
Signed-off-by: Jungkook Lee [email protected]