Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS-ONLY] update create extension params in code coverage github actions #2380

Conversation

tanscorpio7
Copy link
Contributor

@tanscorpio7 tanscorpio7 commented Feb 21, 2024

Description

Provide the correct migration mode value for create extension line in DROP AND RECREATE babelfish db step in code coverage.

Issues Resolved

[NO JIRA]

Test Scenarios Covered

Enable code coverage for first commit temporarily

Sign Off

Signed-off-by: Tanzeel Khan [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 7992105145

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.238%

Totals Coverage Status
Change from base Build 7928620195: 0.0%
Covered Lines: 40400
Relevant Lines: 55926

💛 - Coveralls

Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7 tanscorpio7 changed the title update create extension params in code coverage github actions [OSS-ONLY] update create extension params in code coverage github actions Feb 22, 2024
@shardgupta shardgupta merged commit b4868b3 into babelfish-for-postgresql:BABEL_4_X_DEV Feb 26, 2024
38 checks passed
japinli pushed a commit to japinli/babelfish_extensions that referenced this pull request Mar 1, 2024
…ions (babelfish-for-postgresql#2380)

Provide the correct migration mode value for create extension line in DROP AND RECREATE babelfish db step in code coverage.

Signed-off-by: Tanzeel Khan <[email protected]>
@tanscorpio7 tanscorpio7 deleted the fix_code_coverage branch March 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants