Support double-escaping and unbalanced quotes in sp_tables table_type #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 3x (babelfish-for-postgresql#2475) It is suggested to relax table_type parameter handling in sp_tables procedure, so strings with technically invalid quotation are also accepted. See details in the linked issue. Task resolved: BABEL-4887 Signed-off-by: Alex Kasko <[email protected]>
thephantomthief
approved these changes
Apr 10, 2024
shardgupta
approved these changes
Apr 10, 2024
shardgupta
merged commit 7b0227f
into
babelfish-for-postgresql:BABEL_2_X_DEV
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is suggested to relax table_type parameter handling in sp_tables procedure, so strings with technically invalid quotation are also accepted.
Task: BABEL-4887
cherry-picked from #2405
Authored-by: Alex Kasko [email protected]
Issues Resolved
#2404
Test Scenarios Covered
Existing test is updated with new input.
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.