Fix Crash in handle_where_clause_restargets_right #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gresql#2566) This commit fixes the crash in handle_where_clause_restargets_right and other functions which are used by sp_describe_undeclared_parameters. The crash was happening because we were throwing WARNING instead or ERROR. But, rather than throwing error, it's better to return 0 rows for the unsupported cases to avoid unnecessary application code errors. We keep a flag which says whether we support the specific case or not. Based on that flag we return rows. Issues Resolved BABEL-4869 Signed-off-by: Shameem Ahmed [email protected]
…internal Signed-off-by: Shameem Ahmed <[email protected]>
rishabhtanwar29
approved these changes
May 17, 2024
shardgupta
approved these changes
May 17, 2024
shardgupta
merged commit eda23ea
into
babelfish-for-postgresql:BABEL_2_X_DEV
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes the crash in handle_where_clause_restargets_right and other functions which are used by sp_describe_undeclared_parameters. The crash was happening because we were throwing WARNING instead or ERROR. But, rather than throwing error, it's better to return 0 rows for the unsupported cases to avoid unnecessary application code errors.
We keep a flag which says whether we support the specific case or not. Based on that flag we return rows.
Issues Resolved
BABEL-4869
Signed-off-by: Shameem Ahmed [email protected]
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs - YES
Negative test cases - YES
Minor version upgrade tests - YES
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.