Fix alter table drop constraint not able to drop some constraints

[tanscorpio7]

Description

Babelfish was hashing the constraint name for named table constraints. But no hashing was done for unnamed table constraints, unnamed column constraints or named column constraints. On the other hand the constraint name in DROP CONSTRAINT was always hashed without exception. This means we were failing DROP for all constraints which were not hashed during creation.

As a fix, we have removed the hashing step from named table constraints creation, making creation of constraints consistent for babelfish. This also allows us to remove hashing from DROP CONSTRAINT command.

Not hashing constraint name has one repercussion, Users can now create a PRIMARY KEY/UNIQUE constraint with same name as an existing Index on the same table. This was previously blocked for named table constraints but not for other types of constraints.
We could block this in the future in a more complete way.

Issues Resolved

[BABEL-2047]

Cherry Picked From

#2575

Sign Off

Signed-off-by: Tanzeel Khan [email protected]

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 9193153868

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.004%) to 72.819%

---

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tsql/src/pl_handler.c	1	91.54%
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c	2	74.29%

Totals
Change from base Build 9178755500:	-0.004%
Covered Lines:	41851
Relevant Lines:	57473

---

💛 - Coveralls