Update the column datatype of views where nvarchar(max) is required #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephantomthief
approved these changes
May 28, 2024
rishabhtanwar29
approved these changes
May 28, 2024
shardgupta
approved these changes
May 28, 2024
shardgupta
merged commit e8161c8
into
babelfish-for-postgresql:BABEL_2_X_DEV
29 checks passed
shalinilohia50
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
May 28, 2024
…abelfish-for-postgresql#2612) Update the column datatype of views where nvarchar(max) is required Following views are fixed with this commit: sys.computed_columns sys.xml_indexes sys.stats sys.plan_guides sys.numbered_procedures sys.default_constraints sys.check_constraints Task: BABEL-3401 Signed-off-by: Shalini Lohia [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the column datatype of views where nvarchar(max) is required
Views that needs to fixed:
sys.computed_columns
sys.xml_indexes
sys.stats
sys.plan_guides
sys.numbered_procedures
sys.default_constraints
sys.check_constraints
Issues Resolved
Task: BABEL-3401
Signed-off-by: Shalini Lohia [email protected]
Test Scenarios Covered
Use case based - We already have tests
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.