Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jTDS: support running JDBC tests with jTDS driver #2861

Open
wants to merge 2 commits into
base: BABEL_4_X_DEV
Choose a base branch
from

Conversation

staticlibs
Copy link
Contributor

Description

This PR is a part of a change originally implemented in #2320.

This change to JDBC test harness introduces the jtds_jdbc_schedule list file. To run the test from this new file instead of jdbc_schedule file it is necessary to set useJTDSInsteadOfMSSQLJDBC environment variable to true:

useJTDSInsteadOfMSSQLJDBC=true mvn test

Changes from #2860 PR are required to run jTDS tests successfully.

For jtds_jdbc_schedule file the intention is to use original tests unmodified where possible. Test for which modifications were required (mostly due to data types and error handling differences) are copied with jtds- prefix.

Github workfow file jdbc-tests-with-jtds.yml is included, but tests there are failing until #2860 is integrated. It is based on jdbc-tests-with-parallel-query.yml workflow file.

Issues Resolved

#2137

Test Scenarios Covered

The following tests from the original list are included:

  • sqlBatch
  • errorHandling
  • storedProcedures
  • transactions

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Alex Kasko [email protected]

@staticlibs staticlibs mentioned this pull request Aug 15, 2024
1 task
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10410968113

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.047%

Totals Coverage Status
Change from base Build 10389490935: 0.0%
Covered Lines: 44427
Relevant Lines: 59998

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants