Fix for cache reference leak warning #3161
Open
+31
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Jain <[email protected]>
Pull Request Test Coverage Report for Build 12886386243Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Pranav Jain <[email protected]>
Signed-off-by: Pranav Jain <[email protected]>
Signed-off-by: Pranav Jain <[email protected]>
Signed-off-by: Pranav Jain <[email protected]>
Signed-off-by: Pranav Jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
pranavJ23
changed the title
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
tanscorpio7
suggested changes
Jan 21, 2025
| if(get_bbf_function_tuple_from_proctuple(SearchSysCache1(PROCOID, ObjectIdGetDatum(oldoid))) == NULL) | ||
| proctup = SearchSysCache1(PROCOID, ObjectIdGetDatum(oldoid)); | ||
|
|
||
| if (proctup == NULL) |
There was a problem hiding this comment.
we should use HeapTupleIsValid & curly braces can be removed in next line.
| if (get_bbf_function_tuple_from_proctuple(proctup) == NULL) | ||
| { | ||
| /* Release the tuple before reporting the error */ | ||
| ReleaseSysCache(proctup); |
There was a problem hiding this comment.
In case of error we do not need to release syscache
Signed-off-by: pranav jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: During the Alter function/procedure we are doing a sys-cache search without releasing it.
Fix: was to do sys-cache search via tuple and releasing it after the sys-cache search.
Also we are generating the logfile but the path that we were giving it github action workflow was not correct, updated that too.
Issues Resolved
[BABEL-5551]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.