Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to use newer Java version #3285

Conversation

timchang514
Copy link
Contributor

Description

Updating the README to use a newer Java version. The Antlr version update requires Java 8 at minimum to build.

For Ubuntu, I verified the version openjdk-21-jre was available by using a clean Ubuntu install.

For the RHEL version we typically develop on, the default version of Java available is openjdk-17, so that doesn't need changing.

This is a cherry-pick of #3270

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12418803465

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 866 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 74.848%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tsql/src/pl_handler.c 48 90.09%
contrib/babelfishpg_tds/src/include/tds_request.h 53 74.85%
contrib/babelfishpg_tsql/src/pltsql_utils.c 68 92.23%
contrib/babelfishpg_tsql/runtime/functions.c 108 83.21%
contrib/babelfishpg_tsql/src/procedures.c 144 88.75%
contrib/babelfishpg_tsql/src/catalog.c 202 86.43%
contrib/babelfishpg_tsql/src/tsqlIface.cpp 243 90.11%
Totals Coverage Status
Change from base Build 12395755914: 0.03%
Covered Lines: 46532
Relevant Lines: 62169

💛 - Coveralls

@kuntalghosh kuntalghosh merged commit 8b31d23 into babelfish-for-postgresql:BABEL_5_X_DEV Dec 20, 2024
44 checks passed
@kuntalghosh kuntalghosh deleted the fix-readme-jdk-version-5x branch December 20, 2024 04:29
pranavJ23 pushed a commit to pranavJ23/babelfish_extensions that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants