Do not allow predefined server roles to be members of each other #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12427825146Details
💛 - Coveralls |
Signed-off-by: ANJU BHARTI <[email protected]>
anju15bharti
force-pushed
the
fixed_serv-role
branch
from
ea2983e to
21e2d6e
Compare
HarshLunagariya
suggested changes
Dec 20, 2024
| @@ -1946,6 +1946,12 @@ check_alter_server_stmt(GrantRoleStmt *stmt) | |||
| (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), | |||
| errmsg("'sysadmin' role cannot be granted to login: a user is already created in database '%s'", db_name))); | |||
|
|
|||
| /* Forbidden the use of fixed server principals as grantee*/ | |||
There was a problem hiding this comment.
This seems grammatically incorrect.
Comment on lines
+597
to
+608
| Alter server role dbcreator add member securityadmin | ||
| go | ||
| ~~ERROR (Code: 33557097)~~ | ||
|
|
||
| ~~ERROR (Message: Cannot use the special principal 'securityadmin')~~ | ||
|
|
||
|
|
||
| Alter server role dbcreator add member dbcreator | ||
| go | ||
| ~~ERROR (Code: 33557097)~~ | ||
|
|
||
| ~~ERROR (Message: Cannot use the special principal 'dbcreator')~~ |
There was a problem hiding this comment.
- Please add dbcreator/secadmin <-> sysadmin combination.
- Are there existing testcases for PG endpoint?
There was a problem hiding this comment.
- Added more testcases.
- no it's the behaviour from BBF endpoint and for PG we have already blocked operations on BBF created objects.
HarshLunagariya
approved these changes
Dec 20, 2024
Signed-off-by: ANJU BHARTI <[email protected]>
anju15bharti
force-pushed
the
fixed_serv-role
branch
from
b33ac65 to
c125588
Compare
HarshLunagariya
approved these changes
Dec 20, 2024
shardgupta
approved these changes
Dec 20, 2024
shardgupta
merged commit 3cba022
into
babelfish-for-postgresql:BABEL_5_X_DEV
44 checks passed
anju15bharti
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 20, 2024
…elfish-for-postgresql#3292) Earlier fixed server-level roles could made members of each other. With this commit, we blocked making predefined server-level roles members of each other. Task: BABEL-5484 Signed-off-by: ANJU BHARTI <[email protected]>
shardgupta
pushed a commit
that referenced
this pull request
Dec 20, 2024
…) (#3294) Earlier fixed server-level roles could made members of each other. With this commit, we blocked making predefined server-level roles members of each other. Task: BABEL-5484 Signed-off-by: ANJU BHARTI <[email protected]>
pranavJ23
pushed a commit
to pranavJ23/babelfish_extensions
that referenced
this pull request
Jan 6, 2025
…elfish-for-postgresql#3292) Earlier fixed server-level roles could made members of each other. With this commit, we blocked making predefined server-level roles members of each other. Task: BABEL-5484 Signed-off-by: ANJU BHARTI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier fixed server-level roles could made members of each other.
With this commit, we blocked making predefined server-level roles members of each other.
Issues Resolved
BABEL-5484