Fix sys.dm_exec_sessions having rows for backends which are already terminated #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Pull Request Test Coverage Report for Build 12548175612Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
thephantomthief
approved these changes
Dec 30, 2024
Signed-off-by: Tanzeel Khan <[email protected]>
tanscorpio7
changed the title
tanscorpio7
changed the title
shardgupta
approved these changes
Dec 30, 2024
shardgupta
merged commit df1ce4d
into
babelfish-for-postgresql:BABEL_5_X_DEV
45 checks passed
tanscorpio7
added a commit
to tanscorpio7/babelfish_extensions
that referenced
this pull request
Dec 30, 2024
…erminated (babelfish-for-postgresql#3329) We initialize and keep a local status array which has the entries for all TDS connections but we did not reset these entries during connection abort or shmem exit of the backend, which means future read of this local status array will see these entries as valid. As a fix, mark the status entry as invalid during proc/shmem exit Task: [BABEL-5414] Signed-off-by: Tanzeel Khan [email protected]
1 task
tanscorpio7
added a commit
to tanscorpio7/babelfish_extensions
that referenced
this pull request
Dec 30, 2024
…erminated (babelfish-for-postgresql#3329) We initialize and keep a local status array which has the entries for all TDS connections but we did not reset these entries during connection abort or shmem exit of the backend, which means future read of this local status array will see these entries as valid. As a fix, mark the status entry as invalid during proc/shmem exit Task: [BABEL-5414] Signed-off-by: Tanzeel Khan [email protected]
1 task
tanscorpio7
added a commit
to tanscorpio7/babelfish_extensions
that referenced
this pull request
Dec 30, 2024
…erminated (babelfish-for-postgresql#3329) We initialize and keep a local status array which has the entries for all TDS connections but we did not reset these entries during connection abort or shmem exit of the backend, which means future read of this local status array will see these entries as valid. As a fix, mark the status entry as invalid during proc/shmem exit Task: [BABEL-5414] Signed-off-by: Tanzeel Khan [email protected]
1 task
shardgupta
pushed a commit
that referenced
this pull request
Dec 31, 2024
…erminated (#3329) (#3333) We initialize and keep a local status array which has the entries for all TDS connections but we did not reset these entries during connection abort or shmem exit of the backend, which means future read of this local status array will see these entries as valid. As a fix, mark the status entry as invalid during proc/shmem exit Task: [BABEL-5414] Signed-off-by: Tanzeel Khan [email protected]
shardgupta
pushed a commit
that referenced
this pull request
Dec 31, 2024
…erminated (#3329) (#3332) We initialize and keep a local status array which has the entries for all TDS connections but we did not reset these entries during connection abort or shmem exit of the backend, which means future read of this local status array will see these entries as valid. As a fix, mark the status entry as invalid during proc/shmem exit Task: [BABEL-5414] Signed-off-by: Tanzeel Khan [email protected]
shardgupta
pushed a commit
that referenced
this pull request
Dec 31, 2024
…erminated (#3329) (#3331) We initialize and keep a local status array which has the entries for all TDS connections but we did not reset these entries during connection abort or shmem exit of the backend, which means future read of this local status array will see these entries as valid. As a fix, mark the status entry as invalid during proc/shmem exit Task: [BABEL-5414] Signed-off-by: Tanzeel Khan [email protected]
1 task
pranavJ23
pushed a commit
to pranavJ23/babelfish_extensions
that referenced
this pull request
Jan 6, 2025
…erminated (babelfish-for-postgresql#3329) We initialize and keep a local status array which has the entries for all TDS connections but we did not reset these entries during connection abort or shmem exit of the backend, which means future read of this local status array will see these entries as valid. As a fix, mark the status entry as invalid during proc/shmem exit Task: [BABEL-5414] Signed-off-by: Tanzeel Khan [email protected]
shardgupta
pushed a commit
that referenced
this pull request
Jan 6, 2025
…dm_exec_sessions (#3350) #3329 was not enough to fix abandoned rows in sys.dm_exec_sessions. Sessions terminated using kill command still leave behind an entry in sys.dm_exec_sessions. Root cause was not executing the shmem exit hook when session terminated because of SIGTERM. As a fix make `tds_stats_shmem_shutdown` completely similar to `pgstat_beshutdown_hook`. Task: [BABEL-5414] Signed-off-by: Tanzeel Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We initialize and keep a local status array which has the entries
for all TDS connections but we did not reset these entries during
connection abort or shmem exit of the backend, which means
future read of this local status array will see these entries as valid.
As a fix, mark the status entry as invalid during proc/shmem exit
Issues Resolved
[BABEL-5414]
Sign Off
Signed-off-by: Tanzeel Khan [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.