Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dotnet to v8.0 and upgrade C# dependencies #3334

Conversation

shah-nirmit
Copy link
Contributor

@shah-nirmit shah-nirmit commented Dec 31, 2024

Description

  • Upgrading to Latest Dotnet version for test framework also upgrading to Microsoft.Data.SqlClient driver from System.Data.SqlClient as it is deprecated check link

  • Also upgraded other packages being used to latest versions

Couple of changes for migrating to newer driver

  1. Add a new switch in config called runInRegression to turn off encryption for sqlclient driver as its by default on in the new Package , For More Context check link

  2. Add a appcontext switch to avoid rounding on decimals instead of truncation. More details There seems to be a difference in the way Microsoft.Data.SqlClient treats Decimal values when compared to System.Data.SqlClient dotnet/SqlClient#2905

Signed-off-by: Nirmit Shah [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

coveralls commented Dec 31, 2024

Pull Request Test Coverage Report for Build 12556512235

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 74.883%

Totals Coverage Status
Change from base Build 12555969159: 0.007%
Covered Lines: 46738
Relevant Lines: 62415

💛 - Coveralls

@shardgupta shardgupta merged commit 8931d86 into babelfish-for-postgresql:BABEL_4_X_DEV Dec 31, 2024
47 checks passed
@shardgupta shardgupta deleted the nirmit-dt-upgrade branch December 31, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants