Upgrade dotnet to v8.0 and upgrade C# dependencies #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12556165575Details
💛 - Coveralls |
tanscorpio7
approved these changes
Dec 31, 2024
shardgupta
approved these changes
Dec 31, 2024
shardgupta
merged commit 40cc725
into
babelfish-for-postgresql:BABEL_5_X_DEV
45 checks passed
pranavJ23
pushed a commit
to pranavJ23/babelfish_extensions
that referenced
this pull request
Jan 6, 2025
…tgresql#3335) - Upgrading to Latest Dotnet version for test framework also upgrading to `Microsoft.Data.SqlClient` driver from `System.Data.SqlClient` as it is deprecated check [link](https://techcommunity.microsoft.com/blog/sqlserver/announcement-system-data-sqlclient-package-is-now-deprecated/4227205) - Also upgraded other packages being used to latest versions Couple of changes for migrating to newer driver 1. Add a new switch in config called `runInRegression` to turn off encryption for sqlclient driver as its by default on in the new Package , For More Context check [link](https://github.com/dotnet/SqlClient/blob/main/porting-cheat-sheet.md) 2. Add a appcontext switch to avoid rounding on decimals instead of truncation. More details dotnet/SqlClient#2905 Signed-off-by: Nirmit Shah [[email protected]](mailto:[email protected])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading to Latest Dotnet version for test framework also upgrading to
Microsoft.Data.SqlClientdriver fromSystem.Data.SqlClientas it is deprecated check linkAlso upgraded other packages being used to latest versions
Couple of changes for migrating to newer driver
Add a new switch in config called
runInRegressionto turn off encryption for sqlclient driver as its by default on in the new Package , For More Context check linkAdd a appcontext switch to avoid rounding on decimals instead of truncation. More details There seems to be a difference in the way Microsoft.Data.SqlClient treats Decimal values when compared to System.Data.SqlClient dotnet/SqlClient#2905
Signed-off-by: Nirmit Shah [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.