-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with convert function when converting string to date, datetimeoffset, datetime2, datetime, smalldatetime or time #3336
Merged
shardgupta
merged 11 commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
rohit01010:BABEL-4896
Jan 8, 2025
Merged
Fix issue with convert function when converting string to date, datetimeoffset, datetime2, datetime, smalldatetime or time #3336
shardgupta
merged 11 commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
rohit01010:BABEL-4896
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imeoffset, datetime2, datetime, smalldatetime or time Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Anikait143
reviewed
Jan 6, 2025
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Anikait143
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rishabhtanwar29
approved these changes
Jan 8, 2025
shardgupta
approved these changes
Jan 8, 2025
shardgupta
merged commit Jan 8, 2025
03b6fab
into
babelfish-for-postgresql:BABEL_5_X_DEV
45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add fix for following issues:
Cherry-picked from: #2622, #2653
Authored-by: Rohit Bhagat [email protected]
Signed-off-by: Rohit Bhagat [email protected]
Issues Resolved
BABEL-4896
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs - YES
Negative test cases - YES
Minor version upgrade tests - YES
Major version upgrade tests - YES
Performance tests - NA
Tooling impact - NA
Client tests - YES
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.